Adding Symfony4 support #171
Conversation
v4 doesn't generate correct mocks for 7.1 classes Tests are failing with: Fatal error: Declaration of Mock_ContainerBuilder_15214828::getReflectionClass(string $class, bool $throw = true) must be compatible with Symfony\Component\DependencyInjection\ContainerBuilder::getReflectionClass(?string $class, bool $throw = true): ?ReflectionClass
phpunit 5.4.0 deprecated `PHPUnit\Framework\TestCase::getMock()` Replace its usages with the recommended `createMock()` where possible, or with `getMockBuilder()` were `createMock()`'s defaults won't do
for compatibility with php 5.5
Tests are ran with `phpunit@4.5` for `php5.5` and `phpunit@5.7` for all the others. To have the tests working in both versions, avoid using `PHPUnit\Framework\TestCase::createMock()` which was added in `phpunit@5.4.0`.
composer.json
Outdated
| "php": "^5.3.9|^7.0", | ||
| "symfony/framework-bundle": "~2.3|~3.0", | ||
| "symfony/finder": "~2.3|~3.0", | ||
| "php": "^5.3.9|^7.0|^7.1", |
There was a problem hiding this comment.
this change should not be necessary afaik
|
awesome work .. I restarted the one test that failed due to composer manually and now its all green |
|
Please note that the bundle needs more work to make it work in a Symfony Flex directory structure. I've spent some time during the hackday trying to understand what I should update, without too much success. I think keeping compatibility with both |
| "symfony/console": "~2.3|~3.0", | ||
| "symfony/expression-language": "~2.6|~3.0", | ||
| "symfony/templating": "~2.3|~3.0", | ||
| "phpunit/phpunit": "~4.5|~5.7", |
There was a problem hiding this comment.
you may want to allow ^6.0 too
There was a problem hiding this comment.
First I tried using ^6.0, but that phpunit version switches to using PHP namespaces and I thought it would require too many changes in the test files, this is why I stuck with 5.7.
There was a problem hiding this comment.
Switching to the namespaced classes is probably a good idea. But could be done in a different PR IMO.
There was a problem hiding this comment.
At the same time, phpunit 4.5 is required when running the tests under PHP 5.5, because phpunit 5.7 requires PHP ^5.6. So the tests extending namespaced phpunit classes wouldn't be able to run under that version. And requiring PHP^5.6 in this bundle would probably require a major version, to avoid BC...
There was a problem hiding this comment.
You can use 4.8.35 or higher on PHP 5.5 which provides a forward compatible layer for the namespaced classes.
|
Also, as mentioned in a possible issue in the templating component, the templating component is now obsolete, so this bundle (maybe) shouldn't rely on it anymore. @lsmith77 , do you think I should open a new issue (followed, hopefully by a pull request) suggesting to release Symfony 4 (and Flex directory structure) compatibility in a new major version? That would implement/rely only on the twig bridge? |
|
I would say .. maybe for Symfony 4 we should do a new major version which drops the dependency on the templating component. |
|
see also #173 |
#SymfonyConHackday2017