Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user profile and civic liker oauth api #23

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@williamchong007
Copy link
Member

commented Mar 11, 2019

No description provided.

williamchong007 added some commits Mar 11, 2019

Add user profile api
 Add Civic Liker oauth support

@williamchong007 williamchong007 requested review from nnkken and nwingt Mar 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 11, 2019

Codecov Report

Merging #23 into master will decrease coverage by 0.17%.
The diff coverage is 62.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #23      +/-   ##
=========================================
- Coverage   53.27%   53.1%   -0.18%     
=========================================
  Files          57      60       +3     
  Lines        2549    2625      +76     
=========================================
+ Hits         1358    1394      +36     
- Misses       1191    1231      +40
Impacted Files Coverage Δ
config/config.js 100% <ø> (ø) ⬆️
src/util/ValidationHelper.js 62.96% <0%> (-22.04%) ⬇️
src/routes/social/facebook.js 18.03% <100%> (ø) ⬆️
src/middleware/noCache.js 100% <100%> (ø)
src/routes/coupon/index.js 25% <100%> (ø) ⬆️
src/routes/social/medium.js 26.82% <100%> (ø) ⬆️
src/routes/users/setInfo.js 45.45% <100%> (ø) ⬆️
src/routes/payment/index.js 27.08% <100%> (ø) ⬆️
src/util/firebase.js 86.48% <100%> (ø) ⬆️
src/routes/civic/index.js 84.9% <100%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec7a7a...dd9ef04. Read the comment docs.

@nnkken

nnkken approved these changes Mar 12, 2019

@williamchong007 williamchong007 merged commit 450d8b0 into likecoin:master Mar 14, 2019

5 checks passed

ci/circleci: build_and_test/hold_deploy_rinkeby_api Your job was approved on CircleCI!
Details
ci/circleci: deploy_rinkeby_api Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 62.2% of diff hit (target 53.27%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +8.92% compared to 0ec7a7a
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.