Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Add email based LikerID prefill #1059

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@williamchong007
Copy link
Member

williamchong007 commented Mar 18, 2019

No description provided.

@williamchong007 williamchong007 requested review from nnkken, mckingho and nwingt Mar 18, 2019

@williamchong007 williamchong007 force-pushed the williamchong007:master branch 3 times, most recently from c4832f1 to 6e1a911 Mar 18, 2019

@williamchong007 williamchong007 force-pushed the williamchong007:master branch from 6e1a911 to 041644d Mar 18, 2019

}
}
}
tryName = `${suggestedName}${String(Math.ceil(Math.random() * 10000)).padStart(RANDOM_DIGIT_LENGTH, '0')}`;

This comment has been minimized.

Copy link
@nnkken

nnkken Mar 18, 2019

Member

tryName is always changed even if isIDAvailable is true

This comment has been minimized.

Copy link
@nnkken

nnkken Mar 18, 2019

Member

Also, should the harcoded 10000 depends on the value of RANDOM_DIGIT_LENGTH, say Math.pow(10, RANDOM_DIGIT_LENGTH)?

This comment has been minimized.

Copy link
@williamchong007

williamchong007 Mar 18, 2019

Author Member

Updated to use break and Math.floor + **

@nnkken

nnkken approved these changes Mar 18, 2019

@williamchong007 williamchong007 merged commit 463fc5a into likecoin:master Mar 18, 2019

5 of 6 checks passed

ci/circleci: build_and_test/hold_deploy_rinkeby_api Your job is on hold on CircleCI!
Details
ci/circleci: build_and_test/hold_deploy_rinkeby_frontend Your job was approved on CircleCI!
Details
ci/circleci: deploy_rinkeby_frontend Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: unit_test Your tests passed on CircleCI!
Details
security/snyk - package.json (likecoin) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.