Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os 2 failed to save history error after every command #39

Open
ribosomerocker opened this issue Oct 28, 2020 · 3 comments
Open

os 2 failed to save history error after every command #39

ribosomerocker opened this issue Oct 28, 2020 · 3 comments

Comments

@ribosomerocker
Copy link

ribosomerocker commented Oct 28, 2020

The Error: Failed to save history: No such file or directory (os error 2) error occurs after inputting every command on fish.

@ribosomerocker ribosomerocker changed the title os 2 error after every command on fish os 2 failed to save history error after every command on fish Oct 28, 2020
@ribosomerocker
Copy link
Author

This needs the ~/.config/crush directory created manually, any chance it could be created automatically if it wasn't found?

@stormasm
Copy link

I have never used crush before until today. I am coming from the nushell world and wanted to try out crush. I built it from the github repo using cargo build. Ran the binary and got the error message listed here.

One of 4 things should happen.

  1. in the Readme for building and installing crush having a config file should be documented, there is no mention of it. So when I run crush my first experience is not good.
  2. document a way to have a config file get created by running an init command.
  3. don't throw the error you are throwing but instead say "create a config file"
  4. don't require the config file so we don't see this message

@ribosomerocker
Copy link
Author

If you navigate your way from the readme to the config.md file https://github.com/liljencrantz/crush/blob/master/docs/config.md, you can see it talking about the config file, I do agree that crush should either not require it being created or create it automatically if it wasn't find, since it wouldn't be hard to do, I can get a PR ready if the author would like me to do so. I kind of have a hunch that the 4th point would be preferred, though, so I'm not sure.

@ribosomerocker ribosomerocker changed the title os 2 failed to save history error after every command on fish os 2 failed to save history error after every command Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants