From af5ea8600335b15d0d8b023b5b0a31f099fc8de9 Mon Sep 17 00:00:00 2001 From: Jan Dubois Date: Fri, 22 Aug 2025 12:54:00 -0700 Subject: [PATCH] Don't configure video or keyboard devices when -display is "none" Signed-off-by: Jan Dubois --- pkg/driver/qemu/qemu.go | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/pkg/driver/qemu/qemu.go b/pkg/driver/qemu/qemu.go index 9f3c12d9851..2138893e37b 100644 --- a/pkg/driver/qemu/qemu.go +++ b/pkg/driver/qemu/qemu.go @@ -851,16 +851,18 @@ func Cmdline(ctx context.Context, cfg Config) (exe string, args []string, err er args = appendArgsIfNoConflict(args, "-display", display) } - switch *y.Arch { - // FIXME: use virtio-gpu on all the architectures - case limayaml.X8664, limayaml.RISCV64: - args = append(args, "-device", "virtio-vga") - default: - args = append(args, "-device", "virtio-gpu") + if *y.Video.Display != "none" { + switch *y.Arch { + // FIXME: use virtio-gpu on all the architectures + case limayaml.X8664, limayaml.RISCV64: + args = append(args, "-device", "virtio-vga") + default: + args = append(args, "-device", "virtio-gpu") + } + args = append(args, "-device", "virtio-keyboard-pci") + args = append(args, "-device", "virtio-"+input+"-pci") + args = append(args, "-device", "qemu-xhci,id=usb-bus") } - args = append(args, "-device", "virtio-keyboard-pci") - args = append(args, "-device", "virtio-"+input+"-pci") - args = append(args, "-device", "qemu-xhci,id=usb-bus") // Parallel args = append(args, "-parallel", "none")