Skip to content

Display the error when the plugin command failed to run #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

Display the error when the plugin command failed to run #3902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cmd/limactl/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,16 +242,18 @@ func runExternalPlugin(ctx context.Context, name string, args []string) {
return
}

logrus.Debugf("found external command: %s", execPath)

cmd := exec.CommandContext(ctx, execPath, args...)
cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
cmd.Env = os.Environ()

handleExitCoder(cmd.Run())
os.Exit(0) //nolint:revive // it's intentional to call os.Exit in this function
err = cmd.Run()
handleExitCoder(err)
if err == nil {
os.Exit(0) //nolint:revive // it's intentional to call os.Exit in this function
}
logrus.Fatalf("external command %q failed: %v", execPath, err)
}

func updatePathEnv() error {
Expand Down