Skip to content

Ask QEMU for virtio-scsi instead of virtio-scsi-pci #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

Ask QEMU for virtio-scsi instead of virtio-scsi-pci #4406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/driver/qemu/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func Cmdline(ctx context.Context, cfg Config) (exe string, args []string, err er
// cloud-init
args = append(args,
"-drive", "id=cdrom0,if=none,format=raw,readonly=on,file="+filepath.Join(cfg.InstanceDir, filenames.CIDataISO),
"-device", "virtio-scsi-pci,id=scsi0",
"-device", "virtio-scsi,id=scsi0",
"-device", "scsi-cd,bus=scsi0.0,drive=cdrom0")
Copy link
Member

@nirs nirs Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need scsi cdrom?

We can use virtio:

-drive file=cidata.iso,media=cdrom,if=virtio

Or just:

-cdrom cidata.iso

Copy link
Member Author

@jandubois jandubois Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preferences what-so-ever. @AkihiroSuda / @afbjorklund What do you think?

Copy link
Member

@afbjorklund afbjorklund Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the distribution, I think. And it seems unrelated to this change, with a more portable device.

Copy link
Member

@afbjorklund afbjorklund Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, it was the matter of /dev/hda vs /dev/sda vs /dev/vda and matching kernel support

Copy link

@Vogtinator Vogtinator Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC -cdrom is highly arch/machine specific, using IDE on x86(_64), virtio-blk on aarch64 and s390x, spapr-vscsi on ppc64, ...


// Kernel
Expand Down
1 change: 0 additions & 1 deletion templates/_images/opensuse-leap-16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ images:
- location: https://download.opensuse.org/distribution/leap/16.0/appliances/Leap-16.0-Minimal-VM.aarch64-Cloud.qcow2
arch: aarch64

# s390x image will not boot until https://bugzilla.suse.com/show_bug.cgi?id=1252096 is resolved
- location: https://download.opensuse.org/distribution/leap/16.0/appliances/Leap-16.0-Minimal-VM.s390x-s390x-Cloud.qcow2
arch: s390x
Loading