Skip to content

Allow forwarding X11 to VM #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

jordemort
Copy link
Contributor

This allows people who have XQuartz installed to easily install and run X11 applications inside lima.

This is a nicer replacement for #875 - it adds two new settings to the ssh section of the template - forwardX11 and forwardX11Trusted correspond to the similarly-named ssh options, like forwardAgent does.

This allows people who have XQuartz installed to easily install and run
X11 applications inside lima.

Signed-off-by: Jordan Webb <jordan@caketop.app>
@jordemort
Copy link
Contributor Author

It's unclear to me why the alpine test is failing here

@jordemort
Copy link
Contributor Author

Looks like the alpine test cleared itself up somehow? I did not intervene.

@AkihiroSuda
Copy link
Member

Looks like the alpine test cleared itself up somehow? I did not intervene.

I restarted the CI and it became green

@jandubois
Copy link
Member

I'm not keen on adding every SSH option individually to lima.yaml, but I guess having a generic mechanism to provide "any" additional options might be error-prone.

So, I'm not sure what I'm saying. I guess I'm fine with adding these 2 options, but if the list continues to grow, then this might become unmaintainable.

I'm going to approve this PR based on the code changes, but will leave the merging to @AkihiroSuda

@jordemort
Copy link
Contributor Author

@jandubois Yeah it could get ugly if there are too many more of these. I could whip up an "arbitrary SSH option" PR if you'd rather; I think it could be done at least semi-safely, by filtering out the ones limactl cares about for its own use.

On the other hand, for at least my personal use case, I can't see wanting much else beyond this. The UNIX socket forwarding stuff that was added covers the rest of the weird stuff I want to do (GPG agent, PulseAudio, etc)

@AkihiroSuda AkihiroSuda added this to the v0.11.1 milestone Jun 8, 2022
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Member

"arbitrary SSH option"

SGTM, but this PR also makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants