-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createNormalDatabase returns error if bed has overlapping intervals #28
Comments
Hi Andrew, I thought I have fixed this, but somehow you have single base intervals in your interval file: Target total_coverage counts on_target duplication_rate It's usually much better to use the baits, not the targets file. In the baits file, you should never have such small intervals for which the GC normalization won't work. Also, I would only add baits from standard chromosomes (chr1-chrY). |
Thank you so much for your fast reply and advice. I am confused about the difference between bait and target intervals. Bait intervals in Picard nomenclature ~= what Illumnia calls "probe" intervals? Thank you |
Yep, there are usually two BED files for every capture kit. The first is the location of the actual baits or probes, the second the targets (the exact locations of targeted exons, promotors etc.). Baits are better, because they should give a more even coverage distrbution and a better GC-normalization for short targets. The documentation is confusing here, I'll clean this up as soon as possible. It's still a bug, it shouldn't crash with single nucleotide intervals. |
Thank you for the super clear explanation! |
Was this interval file generated by preprocessIntervals? I'm trying to reproduce, but I get something like this: Target gc_bias mappability reptiming Gene on_target not the crashing Target gc_bias mappability reptiming Gene on_target |
Yes, it was, however possibly with an older version of the package. I also cannot reproduce this now. |
I just grepped these lines out of my intervals, so don't fix on my behalf at this point. |
Okay, yes, I think fixed this in 1.7 something. 1.9. should also remove the KIR alt contigs (I use the hg38 version without ALTs). |
OK thanks. I somehow regressed to an older package version with the move to R 3.5, but I am on dev now. Sorry for the trouble, thanks again, please feel free to close. |
Hello Marcus,
I note that if and only if an input
.bed
file has overlapping intervals:createNormalDatabase
returns an error due toin
PureCN:::getSexFromCoverage
:I am using the latest dev version of the package on the latest R. I have created about 40 normal databases without error if the overlapping intervals message does not appear.
Minimun reproducible example:
Should I pre-filter these, or perhaps add a tryCatch here?
Thank you very much,
Andrew
The text was updated successfully, but these errors were encountered: