From e76549478ce99da3fa37e85c07c7088274c25650 Mon Sep 17 00:00:00 2001 From: Mohammad Zolfaghari Date: Thu, 17 Mar 2016 13:31:52 +0330 Subject: [PATCH] sublime packages tests --- lib/packages/simple.go | 2 ++ lib/sublime/package_test.go | 21 ++++++++++++++------- lib/sublime/sublime_api_generated.go | 4 +--- lib/sublime/testdata/packages/plugin.py | 0 4 files changed, 17 insertions(+), 10 deletions(-) create mode 100644 lib/sublime/testdata/packages/plugin.py diff --git a/lib/packages/simple.go b/lib/packages/simple.go index 8a35d33..8c0fddb 100644 --- a/lib/packages/simple.go +++ b/lib/packages/simple.go @@ -18,6 +18,8 @@ type simple struct { marshal json.Unmarshaler } +// TODO: better errors, maybe we should introduce error type and let +// the loader decide how to log func (s *simple) Load() { log.Debug("Loading %s", s.Name()) data, err := ioutil.ReadFile(s.filename) diff --git a/lib/sublime/package_test.go b/lib/sublime/package_test.go index 25c4c9f..82c77e6 100644 --- a/lib/sublime/package_test.go +++ b/lib/sublime/package_test.go @@ -8,23 +8,30 @@ import ( "path" "testing" - "github.com/limetext/lime-backend/lib" _ "github.com/limetext/lime-backend/lib/commands" "github.com/limetext/lime-backend/lib/packages" ) func TestLoadPlugin(t *testing.T) { + pn := path.Join("testdata", "packages", "plugin.py") + pkg := newPKG(path.Join("testdata", "packages")).(*pkg) + pkg.loadPlugin(pn) + if _, exist := pkg.plugins[pn]; !exist { + t.Errorf("Expected to %s exist in %s package plugins", pn, pkg.Name()) + } } func TestLoadPlugins(t *testing.T) { + pn := path.Join("testdata", "packages", "plugin.py") + pkg := newPKG(path.Join("testdata", "packages")).(*pkg) + pkg.loadPlugins() + if _, exist := pkg.plugins[pn]; !exist { + t.Errorf("Expected to %s exist in %s package plugins", pn, pkg.Name()) + } } -func TestLoadKeyBindings(t *testing.T) { - -} - -func TestLoadSettings(t *testing.T) { - +func init() { + packages.Unregister(packageRecord) } diff --git a/lib/sublime/sublime_api_generated.go b/lib/sublime/sublime_api_generated.go index 2043325..340ec3d 100644 --- a/lib/sublime/sublime_api_generated.go +++ b/lib/sublime/sublime_api_generated.go @@ -148,9 +148,7 @@ func sublime_PackagesPath(tu *py.Tuple) (py.Object, error) { var ( arg1 string ) - if tu.Not() { - arg1 = "default" - } else if v, err := tu.GetItem(0); err != nil { + if v, err := tu.GetItem(0); err != nil { return nil, err } else { if v3, err2 := fromPython(v); err2 != nil { diff --git a/lib/sublime/testdata/packages/plugin.py b/lib/sublime/testdata/packages/plugin.py new file mode 100644 index 0000000..e69de29