-
Notifications
You must be signed in to change notification settings - Fork 3
Add the ability to create models from synphot SourceSpectrum #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 91.38% 91.37% -0.02%
==========================================
Files 52 52
Lines 3728 3744 +16
==========================================
+ Hits 3407 3421 +14
- Misses 321 323 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One question: synphot.SourceSpectrum includes redshift. Should we keep it as z=0? (How can we ensure that?)
I added a check to the code that z is not greater than zero. This means we can apply all redshift through one single code path. I added some notes to this to the notebook and a test for it as well. |
Add a helper function to create
StaticSEDSourcemodels from synphotSourceSpectrummodels so users do not need to manually define the synphot model, generate the SED, etc.