-
Notifications
You must be signed in to change notification settings - Fork 3
Rename the first batch of "sources" to "models" #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 53 53
Lines 3767 3767
=======================================
Hits 3447 3447
Misses 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting my current comments to avoid losing them; I've gone through all .py files and am about to begin .ipynb files
Co-authored-by: Olivia Lynn <olynn@andrew.cmu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Olivia Lynn <olynn@andrew.cmu.edu>
This is the first PR in solving #418. Changes a bunch of the classes with source in the name to model. Also changes MultiSourceModel to MultiObjectModel