-
Notifications
You must be signed in to change notification settings - Fork 3
Wrap the Redback Models #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace TDAstro with LightCurveLynx.
| "As in other examples, we want to make the parameters dynamic to mirror a real simulation. Let's start by drawing:\n", | ||
| "\n", | ||
| " * The location (`RA`, `dec`) uniformly from the footprint of the survey.\n", | ||
| " * The start time (`t0`) uniformly from the coverage of the survey.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| " * The start time (`t0`) uniformly from the coverage of the survey.\n", | |
| " * The start time (`t0`, days) uniformly from the coverage of the survey.\n", |
| "\n", | ||
| "As in other examples, we want to make the parameters dynamic to mirror a real simulation. Let's start by drawing:\n", | ||
| "\n", | ||
| " * The location (`RA`, `dec`) uniformly from the footprint of the survey.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| " * The location (`RA`, `dec`) uniformly from the footprint of the survey.\n", | |
| " * The location (`RA`, `dec`, both in degrees) uniformly from the footprint of the survey.\n", |
| " * The location (`RA`, `dec`) uniformly from the footprint of the survey.\n", | ||
| " * The start time (`t0`) uniformly from the coverage of the survey.\n", | ||
| " * The `redshift` uniformly from [0.0, 0.1]\n", | ||
| " * The mass ejecta (`mej`) as a Gaussian with mean 0.05\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess...
| " * The mass ejecta (`mej`) as a Gaussian with mean 0.05\n", | |
| " * The mass ejecta (`mej`, solar masses) as a Gaussian with mean 0.05\n", |
| "\n", | ||
| "For the rest of the parameters we will set as constants (though these could also use samplers):\n", | ||
| "\n", | ||
| " * Gray opacity (`kappa`) = 1\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess
| " * Gray opacity (`kappa`) = 1\n", | |
| " * Gray opacity (`kappa`, cm^2/g) = 1\n", |
| "For the rest of the parameters we will set as constants (though these could also use samplers):\n", | ||
| "\n", | ||
| " * Gray opacity (`kappa`) = 1\n", | ||
| " * Temperature floor in K (`temperature_floor`) = 3000\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| " * Temperature floor in K (`temperature_floor`) = 3000\n", | |
| " * Temperature floor in K (`temperature_floor`, kelvins) = 3000\n", |
| "\n", | ||
| " * Gray opacity (`kappa`) = 1\n", | ||
| " * Temperature floor in K (`temperature_floor`) = 3000\n", | ||
| " * Minimum initial velocity (`vej`) = 0.2\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing again =)
| " * Minimum initial velocity (`vej`) = 0.2\n", | |
| " * Minimum initial velocity (`vej`, fraction of the speed of light) = 0.2\n", |
| "source": [ | ||
| "## Using Redback Priors\n", | ||
| "\n", | ||
| "Redback models have the ability to draw their parameters using samples from the `bilby` package. We can either define these priors manually or use one of the many sets of priors that are predefined in the redback package ([more information on redback priors here](https://redback.readthedocs.io/en/latest/priors.html). Now let’s load the predefined priors for the \"one_component_kilonova_model\".\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "Redback models have the ability to draw their parameters using samples from the `bilby` package. We can either define these priors manually or use one of the many sets of priors that are predefined in the redback package ([more information on redback priors here](https://redback.readthedocs.io/en/latest/priors.html). Now let’s load the predefined priors for the \"one_component_kilonova_model\".\n", | |
| "Redback models have the ability to draw their parameters using samples from the `bilby` package. We can either define these priors manually or use one of the many sets of priors that are predefined in the redback package ([more information on redback priors here](https://redback.readthedocs.io/en/latest/priors.html)). Now let’s load the predefined priors for the \"one_component_kilonova_model\".\n", |
Co-authored-by: Konstantin Malanchev <hombit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the notebook looks great!
This PR provides an initial proof of concept wrapper for redback models in TDAstro, including a demo notebook.
Replaces #433 and #410