Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

Closes #487

The node label was being passed to the superclass via kwargs. Since those were also passed to internal function nodes, those nodes were getting the same label. This change passes node label directly so it does not get passed to the function nodes.

@jeremykubica jeremykubica requested a review from hombit September 22, 2025 14:24
@jeremykubica jeremykubica merged commit 72b255e into main Sep 22, 2025
7 checks passed
@jeremykubica jeremykubica deleted the issue487 branch September 22, 2025 14:29
@github-actions
Copy link

Before [7c1b80b] After [df00b08] Ratio Benchmark (Parameter)
676±30μs 715±20μs 1.06 benchmarks.TimeSuite.time_fnu_to_flam
4.71±0.02ms 4.89±0.08ms 1.04 benchmarks.TimeSuite.time_lightcurve_source
47.5±0.8μs 48.8±0.3μs 1.03 benchmarks.TimeSuite.time_make_new_salt3_model
30.5±0.4μs 31.2±0.3μs 1.02 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
19.4±0.3ms 19.6±0.4ms 1.01 benchmarks.TimeSuite.time_chained_evaluate_sed
8.76±0.09ms 8.82±0.05ms 1.01 benchmarks.TimeSuite.time_load_passbands
1.04±0.02s 1.05±0.01s 1.01 benchmarks.TimeSuite.time_make_x1_from_hostmass
7.74±0.1ms 7.75±0.3ms 1 benchmarks.TimeSuite.time_apply_white_noise
109±0.9μs 110±0.4μs 1 benchmarks.TimeSuite.time_sample_x0_from_distmod
13.0±0.09μs 13.0±0.1μs 1 benchmarks.TimeSuite.time_sample_x1_from_hostmass

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sampling from the AGN model fails if any node_label specified

3 participants