Skip to content

Conversation

@cchris28
Copy link
Collaborator

Change Description

namespace packages seem to require an actual commit to correctly installj.
Without the commit the namespace package does not include the subpackage
resulting in import failures. If your project is "acme-widget" namespace is "acme" and your subpackage is
"widget" then
import acme.widget
will fail because site-packages will have "acme-widget" and "acme" but "acme" will not have "acme/widget".

Having an actual commit fixes this. I do not understand why it matters.

Checklist

  • [] This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • [] This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@cchris28 cchris28 requested a review from drewoldag July 29, 2023 15:28
@cchris28 cchris28 self-assigned this Jul 31, 2023
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for all the effort here!

@cchris28 cchris28 merged commit ee9cc6f into main Jul 31, 2023
@cchris28 cchris28 deleted the cchris28/ci-build-fix branch July 31, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants