Adding pre-commit hook to prevent committing large files #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchris28
approved these changes
Mar 11, 2023
Collaborator
cchris28
left a comment
cchris28
left a comment
There was a problem hiding this comment.
500 Kbytes probably too restrictive. Maybe 2 Mbytes? That said this is probably ok for a default value.
Collaborator
Author
|
I'm ok leaving the size limit as is for now and we can change it if we get feedback that it's causing problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More docs can be found here about this hook: https://github.com/pre-commit/pre-commit-hooks#check-added-large-files
Seems like it plays nicely with git-lfs by ignoring anything tracked by git-lfs.
Currently set to 500kb limit, and of course the user has control over this. They can either change the pre-commit argument from
-maxkb=500to whatever they want, or ignore the warning withgit commit -m '...' --no-verify.