Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nativ/fix ascii and tty #118

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

@assafnativ
Copy link

@assafnativ assafnativ commented Oct 3, 2016

No description provided.

qrcode/main.py Outdated
@@ -27,12 +27,13 @@ def _check_box_size(size):
class QRCode:
def __init__(self, version=None,
error_correction=constants.ERROR_CORRECT_M,
box_size=10, border=4,
box_size=50, border=1,
Copy link

@kuhne kuhne Oct 3, 2016

This is not a good idea. 3rd party code may rely on the standard values box_size=10 and border=4
If you change the standard values users will get unexpected results

Copy link
Author

@assafnativ assafnativ Mar 9, 2017

Fixed

@assafnativ assafnativ force-pushed the nativ/fix_ascii_and_tty branch 2 times, most recently from 97f79e0 to 5069c43 Oct 3, 2016
Fix the colors support for the two encoders
@assafnativ assafnativ force-pushed the nativ/fix_ascii_and_tty branch from 5069c43 to 2ae3b95 Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants