Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling this extension on my blog breaks the sub-heading detection and thus the TOC #24

Closed
kaushalmodi opened this issue Jun 6, 2022 · 2 comments

Comments

@kaushalmodi
Copy link

Hello,

I have started using your Unclutter extension on Firefox (v101.0) and it's working really well on the few websites I tried it on.

But when I tried it on my blog, I saw it fail: https://scripter.co/zero-html-validation-errors/

Here is what I expected Unclutter's TOC to show but on the left side:

image

But when I run Unclutter, it seems to mis-parse in between headings:

image

You can see that it's missing these headings:

  • 3. Ensure that all images ..
  • Validation Ignores
  • Summary

Also, once I disable Unclutter, that same page shows like this (it's missing the TOC that I had earlier on the right side, also the CSS in the header, around the pre blocks, etc. looks off):

image

Running Ctrl + F5 fixes those CSS problems.

Please let me know if this is something that can be fixed on Unclutter side or it's my mistake.

Thanks!

@phgn0
Copy link
Contributor

phgn0 commented Jun 7, 2022

Hey, thanks for reporting this!

Apparently, Unclutter was excluding the missing headings because of logic to hide "related articles" links many people use on their websites (often a link within an element). I just fixed this bug by allowing links within the same article: 77090e8

Screenshot 2022-06-07 at 1 42 54 PM

This should be released with 0.15.4 on Firefox -- please let me know once you get the update!

I created #25 for the broken style after disabling Unclutter.

@kaushalmodi
Copy link
Author

kaushalmodi commented Jun 7, 2022

Wow! Thank you for fixing this so quickly! 💯

I confirm the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants