diff --git a/core/src/main/java/com/linecorp/armeria/common/logging/ClientConnectionTimings.java b/core/src/main/java/com/linecorp/armeria/common/logging/ClientConnectionTimings.java index 7dd8ac9fc86..63c6cf07437 100644 --- a/core/src/main/java/com/linecorp/armeria/common/logging/ClientConnectionTimings.java +++ b/core/src/main/java/com/linecorp/armeria/common/logging/ClientConnectionTimings.java @@ -108,10 +108,7 @@ public long dnsResolutionStartTimeMicros() { * @return the start time, or {@code -1} if there was no action to resolve a domain name. */ public long dnsResolutionStartTimeMillis() { - if (dnsResolutionStartTimeMicros >= 0) { - return TimeUnit.MICROSECONDS.toMillis(dnsResolutionStartTimeMicros); - } - return -1; + return toMillis(dnsResolutionStartTimeMicros); } /** @@ -138,10 +135,7 @@ public long socketConnectStartTimeMicros() { * @return the start time, or {@code -1} if there was no action to connect to a remote peer. */ public long socketConnectStartTimeMillis() { - if (socketConnectStartTimeMicros >= 0) { - return TimeUnit.MICROSECONDS.toMillis(socketConnectStartTimeMicros); - } - return -1; + return toMillis(socketConnectStartTimeMicros); } /** @@ -168,10 +162,7 @@ public long tlsHandshakeStartTimeMicros() { * @return the start time, or {@code -1} if there was no action to TLS handshake. */ public long tlsHandshakeStartTimeMillis() { - if (tlsHandshakeStartTimeMicros >= 0) { - return TimeUnit.MICROSECONDS.toMillis(tlsHandshakeStartTimeMicros); - } - return -1; + return toMillis(tlsHandshakeStartTimeMicros); } /** @@ -200,10 +191,7 @@ public long pendingAcquisitionStartTimeMicros() { * @return the start time, or {@code -1} if there was no action to get a pending connection. */ public long pendingAcquisitionStartTimeMillis() { - if (pendingAcquisitionStartTimeMicros >= 0) { - return TimeUnit.MICROSECONDS.toMillis(pendingAcquisitionStartTimeMicros); - } - return -1; + return toMillis(pendingAcquisitionStartTimeMicros); } /** @@ -255,4 +243,11 @@ public String toString() { buf.append('}'); return buf.toString(); } + + private static long toMillis(long micro) { + if (micro >= 0) { + return TimeUnit.MICROSECONDS.toMillis(micro); + } + return -1; + } }