Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (ServerBuilder|VirtualHostBuilder).decorator(DecoratingServiceFunction) #1882

Closed
trustin opened this issue Jul 9, 2019 · 1 comment
Closed

Add (ServerBuilder|VirtualHostBuilder).decorator(DecoratingServiceFunction) #1882

trustin opened this issue Jul 9, 2019 · 1 comment
Labels
new feature
Milestone
0.89.0

Comments

@trustin
Copy link
Collaborator

trustin commented Jul 9, 2019

.. so that a user can decorate a server with an ad-hoc decorator implementation:

ServerBuilder sb = new ServerBuilder();
sb.decorator((delegate, ctx, req) -> {
    ...
    return delegate.serve(ctx, req);
});
@trustin trustin added this to the 0.89.0 milestone Jul 9, 2019
@hyeonjames hyeonjames mentioned this issue Jul 14, 2019
Merged
trustin pushed a commit that referenced this issue Jul 22, 2019
@hyeonjames @trustin
Add `(ServerBuilder|VirtualHostBuilder).decorator(DecoratingSer… (#1900)
86b10bd 
.. so that a user can decorate a server with an ad-hoc decorator implementation:

ServerBuilder sb = new ServerBuilder();
sb.decorator((delegate, ctx, req) -> {
    ...
    return delegate.serve(ctx, req);
});

See #1882
@trustin
Copy link
Collaborator Author

trustin commented Jul 24, 2019

Fixed by @hyeonjames via #1900. Thanks again!

@trustin trustin closed this as completed Jul 24, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this issue Sep 19, 2020
@hyeonjames @trustin
Add `(ServerBuilder|VirtualHostBuilder).decorator(DecoratingSer… (lin…
5602b74 
…e#1900)

.. so that a user can decorate a server with an ad-hoc decorator implementation:

ServerBuilder sb = new ServerBuilder();
sb.decorator((delegate, ctx, req) -> {
    ...
    return delegate.serve(ctx, req);
});

See line#1882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
0.89.0
Development

No branches or pull requests
1 participant
@trustin