Make 'none+' serialization format as optional.

[rmohta]

Motivation:

Improve API UX, by not forcing application to provide none+ serialization format.

Modifications:

• Update Scheme.parse() and tryParse() to default to none+, if no serialization format is passed.
• Update DefaultClientFactory to normalize URI by removing none+ from URI scheme.

Result:

• Fixes Accept URIs without none+ and return URIs without none+ #2219

[trustin]

Thanks!

[codecov]

Codecov Report

Merging #2241 into master will increase coverage by 0.03%.
The diff coverage is 84.21%.

@@             Coverage Diff              @@
##             master    #2241      +/-   ##
============================================
+ Coverage      73.5%   73.54%   +0.03%     
- Complexity     9747     9766      +19     
============================================
  Files           849      852       +3     
  Lines         37575    37628      +53     
  Branches       4616     4631      +15     
============================================
+ Hits          27620    27674      +54     
+ Misses         7587     7578       -9     
- Partials       2368     2376       +8

Impacted Files	Coverage Δ	Complexity Δ
.../linecorp/armeria/client/DefaultClientFactory.java	76.66% <100%> (+3.08%)	19 <3> (+3)	⬆️
.../main/java/com/linecorp/armeria/common/Scheme.java	86.48% <100%> (+12.2%)	16 <2> (+3)	⬆️
...com/linecorp/armeria/client/HttpClientBuilder.java	71.05% <100%> (ø)	9 <1> (ø)	⬇️
...linecorp/armeria/client/AbstractClientFactory.java	41.66% <25%> (ø)	6 <0> (ø)	⬇️
...n/java/com/linecorp/armeria/client/UserClient.java	72.72% <0%> (-11.28%)	11% <0%> (+2%)
.../linecorp/armeria/server/ServiceConfigBuilder.java	57.44% <0%> (-10.89%)	15% <0%> (-7%)
...ava/com/linecorp/armeria/server/ServiceConfig.java	62.71% <0%> (-3.33%)	21% <0%> (+2%)
...om/linecorp/armeria/server/VirtualHostBuilder.java	56.81% <0%> (-1.85%)	59% <0%> (-6%)
...linecorp/armeria/server/ServiceBindingBuilder.java	64.86% <0%> (-1.81%)	20% <0%> (ø)
.../java/com/linecorp/armeria/server/VirtualHost.java	54.4% <0%> (-1.61%)	31% <0%> (-1%)
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582d86...1e29419. Read the comment docs.

[rmohta]

nit: Remove public here and the following methods?

Done. Removed in ClientBuilderTest too.

[ikhoon]

Would you be open, if I open another PR later to add this as a checkstyle check (to prevent this in future)?

We had chat and decided to need more discussion on this issue. I filed an issue for that. #2247
Thank you for nice suggestion and if you have a good idea, leave your opinion on it :-)

[ikhoon]

I have made changes to handle UNDEFINED_URI, but haven't reverted the value of constant. It's because, per this PR - we don't want uri() to return none+.
I think, it would not be idiomatic, to have none+ returned for this special case. We are doing an == check for this constant though.
WDYT?

That is a nice idea! Removing none+ from UNDEFINED_URI is good for me too. Thanks for the detail :-)

[trustin]

LGTM once others' comments are addressed.

[minwoox]

Thanks!

[ikhoon]

Great work + thanks for the fast feedback! 👍 @rmohta

[trustin]

🎉 Thanks a lot, @rmohta!