Abide by the rule Reactive Streams 2.3 #2815
Conversation
Some of the subscribers violated Reactive Stremas 2.3 which is: `Subscriber.onComplete()` and `Subscriber.onError(Throwable t)` MUST NOT call any methods on the `Subscription` or the `Publisher`. https://github.com/reactive-streams/reactive-streams-jvm#2.3 Co-authored-by: ikhoon <ih.pert@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2815 +/- ##
============================================
- Coverage 72.78% 72.71% -0.07%
+ Complexity 11967 11951 -16
============================================
Files 1047 1047
Lines 46618 46616 -2
Branches 5829 5829
============================================
- Hits 33929 33896 -33
- Misses 9705 9727 +22
- Partials 2984 2993 +9 Continue to review full report at Codecov.
|
| @@ -227,7 +227,12 @@ public void onNext(T value) { | |||
| subscription.request(1); | |||
| }); | |||
| } catch (Exception e) { | |||
| onError(e); | |||
| try { | |||
| writer.close(e); | |||
There was a problem hiding this comment.
Question: Don't we need to check whether writer is open like we did in onError(...)?
There was a problem hiding this comment.
I think it's okay just to call it because we checked it at line 214.
| assert subscription != null; | ||
| subscription.cancel(); | ||
| } | ||
| writer.close(cause); |
There was a problem hiding this comment.
try...catch and throwIfFatal(...)?
There was a problem hiding this comment.
try...catch and throwIfFatal(...)?
It's done by the caller such as:
https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/stream/AbstractStreamMessage.java#L165
Some of the subscribers violated Reactive Stremas 2.3 which is: `Subscriber.onComplete()` and `Subscriber.onError(Throwable t)` MUST NOT call any methods on the `Subscription` or the `Publisher`. https://github.com/reactive-streams/reactive-streams-jvm#2.3 Co-authored-by: ikhoon <ih.pert@gmail.com>
Some of the subscribers violated Reactive Stremas 2.3 which is:
Subscriber.onComplete()andSubscriber.onError(Throwable t)MUST NOT call any methods on theSubscriptionor thePublisher.https://github.com/reactive-streams/reactive-streams-jvm#2.3
Co-authored-by: ikhoon ih.pert@gmail.com