New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code completion for armeria.ssl #3507
Conversation
Awesome! Could we apply |
Thanks for the education. Good to know that. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @hirakida
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=========================================
Coverage 73.93% 73.93%
- Complexity 14206 14209 +3
=========================================
Files 1245 1245
Lines 54187 54187
Branches 6929 6929
=========================================
+ Hits 40061 40063 +2
+ Misses 10586 10583 -3
- Partials 3540 3541 +1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn't know about this annotation. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice usability boost, @hirakida 🙇
We didn't have code completion for `armeria.ssl`, so I added it. before <img width="587" alt="Screen Shot 2021-05-02 at 16 48 16" src="https://user-images.githubusercontent.com/12070156/116806523-86b6af80-ab68-11eb-8094-43550f2ac1f8.png"> after <img width="591" alt="Screen Shot 2021-05-02 at 16 46 36" src="https://user-images.githubusercontent.com/12070156/116806527-8d452700-ab68-11eb-8bba-b3dfd360e0af.png">
We didn't have code completion for
armeria.ssl
, so I added it.before
after