Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code completion for armeria.ssl #3507

Merged
merged 2 commits into from May 10, 2021

Conversation

hirakida
Copy link
Contributor

@hirakida hirakida commented May 2, 2021

We didn't have code completion for armeria.ssl, so I added it.

before
Screen Shot 2021-05-02 at 16 48 16

after
Screen Shot 2021-05-02 at 16 46 36

@ikhoon ikhoon added this to the 1.8.0 milestone May 2, 2021
@ikhoon
Copy link
Contributor

ikhoon commented May 2, 2021

Awesome! Could we apply NestedConfigurationProperty to other nested property classes?

@hirakida
Copy link
Contributor Author

hirakida commented May 2, 2021

As far as I know, it's okay not to add it to the inner classes.
It seems that it is okay to apply it only to ssl!
Screen Shot 2021-05-02 at 18 06 31

@ikhoon
Copy link
Contributor

ikhoon commented May 3, 2021

As far as I know, it's okay not to add it to the inner classes.

Thanks for the education. Good to know that. 👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @hirakida

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3507 (3bb92c2) into master (031bc8e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3507   +/-   ##
=========================================
  Coverage     73.93%   73.93%           
- Complexity    14206    14209    +3     
=========================================
  Files          1245     1245           
  Lines         54187    54187           
  Branches       6929     6929           
=========================================
+ Hits          40061    40063    +2     
+ Misses        10586    10583    -3     
- Partials       3540     3541    +1     
Impacted Files Coverage Δ Complexity Δ
...a/com/linecorp/armeria/spring/ArmeriaSettings.java 78.78% <ø> (ø) 14.00 <0.00> (ø)
...om/linecorp/armeria/client/HttpSessionHandler.java 73.14% <0.00%> (-8.58%) 49.00% <0.00%> (-4.00%)
...ecorp/armeria/common/stream/StreamMessageUtil.java 76.66% <0.00%> (-6.67%) 11.00% <0.00%> (-1.00%)
...meria/common/stream/RegularFixedStreamMessage.java 88.67% <0.00%> (-5.67%) 14.00% <0.00%> (-1.00%)
...p/armeria/common/stream/FuseableStreamMessage.java 84.26% <0.00%> (-3.38%) 10.00% <0.00%> (ø%)
...rmeria/common/stream/ConcatArrayStreamMessage.java 75.82% <0.00%> (-2.20%) 9.00% <0.00%> (-1.00%)
...p/armeria/common/stream/AbstractStreamMessage.java 85.57% <0.00%> (-1.93%) 15.00% <0.00%> (ø%)
...ria/common/stream/PublisherBasedStreamMessage.java 81.87% <0.00%> (-1.88%) 20.00% <0.00%> (-1.00%)
...ternal/common/stream/DecodedHttpStreamMessage.java 78.26% <0.00%> (-1.74%) 16.00% <0.00%> (-1.00%)
.../com/linecorp/armeria/server/RoutingPredicate.java 70.96% <0.00%> (-1.62%) 21.00% <0.00%> (-1.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031bc8e...3bb92c2. Read the comment docs.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know about this annotation. 😄

Copy link
Collaborator

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usability boost, @hirakida 🙇

@trustin trustin merged commit 8e47d2f into line:master May 10, 2021
@hirakida hirakida deleted the add-ssl-code-completion branch May 10, 2021 07:16
JunoJunho pushed a commit to JunoJunho/armeria that referenced this pull request May 12, 2021
We didn't have code completion for `armeria.ssl`, so I added it.

before
<img width="587" alt="Screen Shot 2021-05-02 at 16 48 16" src="https://user-images.githubusercontent.com/12070156/116806523-86b6af80-ab68-11eb-8094-43550f2ac1f8.png">

after
<img width="591" alt="Screen Shot 2021-05-02 at 16 46 36" src="https://user-images.githubusercontent.com/12070156/116806527-8d452700-ab68-11eb-8bba-b3dfd360e0af.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants