Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #1336

Merged
merged 1 commit into from Aug 20, 2018
Merged

Fix broken link #1336

merged 1 commit into from Aug 20, 2018

Conversation

@matsumana
Copy link
Contributor

@matsumana matsumana commented Aug 14, 2018

I found broken link.

@matsumana matsumana requested review from hyangtack, minwoox and trustin as code owners Aug 14, 2018
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Aug 14, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

@codecov codecov bot commented Aug 14, 2018

Codecov Report

Merging #1336 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   72.52%   72.52%   +<.01%     
==========================================
  Files         601      601              
  Lines       25965    25965              
  Branches     3133     3133              
==========================================
+ Hits        18830    18832       +2     
- Misses       5476     5478       +2     
+ Partials     1659     1655       -4
Impacted Files Coverage Δ
...m/linecorp/armeria/client/HttpResponseDecoder.java 81.81% <0%> (-1.3%) ⬇️
...com/linecorp/armeria/server/HttpServerHandler.java 76.35% <0%> (-1.02%) ⬇️
...corp/armeria/common/logging/DefaultRequestLog.java 80.8% <0%> (ø) ⬆️
...inecorp/armeria/server/HttpResponseSubscriber.java 76.68% <0%> (+0.51%) ⬆️
...rp/armeria/common/stream/DefaultStreamMessage.java 93.43% <0%> (+1.45%) ⬆️
...inecorp/armeria/client/grpc/ArmeriaClientCall.java 81.25% <0%> (+1.56%) ⬆️
.../linecorp/armeria/internal/Http2ObjectEncoder.java 80% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0effcd7...822c85b. Read the comment docs.

@hyangtack hyangtack added this to the 0.70.0 milestone Aug 20, 2018
@hyangtack hyangtack merged commit 69c23a6 into line:master Aug 20, 2018
6 checks passed
6 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch Coverage not affected when comparing 0effcd7...822c85b
Details
@codecov
codecov/project 72.52% (+<.01%) compared to 0effcd7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@hyangtack
Copy link
Contributor

@hyangtack hyangtack commented Aug 20, 2018

Thanks, @matsumana !

@matsumana matsumana deleted the matsumana:fix/link-of-proxy-protocol.txt branch May 9, 2019
filipeGuerreiro pushed a commit to filipeGuerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants