Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate config metadata for Spring #1340

Merged

Conversation

@matsumana
Copy link
Contributor

@matsumana matsumana commented Aug 19, 2018

If metadata is generated, we can use code completion and code jump feature in IntelliJ.
I think that is helpful.


As-Is

To-Be

Unfortunately, the ports property defined with List doesn't seem to be complemented.


Official documentation of Spring Boot:

@matsumana matsumana requested review from hyangtack, minwoox and trustin as code owners Aug 19, 2018
@codecov
Copy link

@codecov codecov bot commented Aug 19, 2018

Codecov Report

Merging #1340 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   72.58%   72.45%   -0.13%     
==========================================
  Files         601      601              
  Lines       25965    25965              
  Branches     3133     3133              
==========================================
- Hits        18846    18813      -33     
- Misses       5468     5499      +31     
- Partials     1651     1653       +2
Impacted Files Coverage Δ
...ecorp/armeria/internal/ReadSuppressingHandler.java 75% <0%> (-25%) ⬇️
...rp/armeria/server/tomcat/ManagedTomcatService.java 50.84% <0%> (-22.04%) ⬇️
...orp/armeria/internal/InboundTrafficController.java 53.84% <0%> (-15.39%) ⬇️
...armeria/server/tomcat/Tomcat90ProtocolHandler.java 50% <0%> (-13.64%) ⬇️
.../linecorp/armeria/internal/Http2ObjectEncoder.java 76% <0%> (-12%) ⬇️
...m/linecorp/armeria/internal/HttpObjectEncoder.java 58.33% <0%> (-8.34%) ⬇️
.../linecorp/armeria/server/tomcat/TomcatService.java 63% <0%> (-2.9%) ⬇️
...p/armeria/common/stream/DeferredStreamMessage.java 86.2% <0%> (-1.73%) ⬇️
...corp/armeria/common/logging/DefaultRequestLog.java 80.8% <0%> (-0.51%) ⬇️
.../linecorp/armeria/internal/IdleTimeoutHandler.java 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0effcd7...a81947d. Read the comment docs.

@trustin trustin added this to the 0.70.0 milestone Aug 19, 2018
@codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Aug 19, 2018

hehe I did not know this.. LG!

@hyangtack hyangtack merged commit a17e920 into line:master Aug 20, 2018
6 checks passed
6 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch Coverage not affected when comparing 0effcd7...a81947d
Details
@codecov
codecov/project 72.45% (-0.13%) compared to 0effcd7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@hyangtack
Copy link
Contributor

@hyangtack hyangtack commented Aug 20, 2018

Thanks, @matsumana !

@matsumana matsumana deleted the matsumana:feature/generate-config-metadata-for-spring branch May 9, 2019
filipeGuerreiro pushed a commit to filipeGuerreiro/armeria that referenced this pull request Sep 19, 2020
If metadata is generated, we can use code completion and code jump feature in IntelliJ.
I think that is helpful.

---

# As-Is

![](https://i.gyazo.com/0e450e5ef6243e56a2c6ce67776c36d8.png)

# To-Be

Unfortunately, the `ports` property defined with List doesn't seem to be complemented.

![](https://i.gyazo.com/c354200c5a19359f2531c5a2eded3a5b.png)

---

Official documentation of Spring Boot:
- [Spring 1.5.x](https://docs.spring.io/spring-boot/docs/1.5.15.RELEASE/reference/html/configuration-metadata.html#configuration-metadata-annotation-processor)
- [Spring 2.0.x](https://docs.spring.io/spring-boot/docs/2.0.4.RELEASE/reference/html/configuration-metadata.html#configuration-metadata-annotation-processor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants