Respect HTTP/2 connection window size #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `InboundTrafficController` uses a hard-coded water mark value of 128KiB, which is much smaller than our current initial connection window size (1MiB). Modifications: - Use the water mark values that matches the initial HTTP/2 connection window size. - HTTP/1 connections' water mark values stay same. Result: - Less frequent network read suspension which was unnecessary.
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
===========================================
- Coverage 72.26% 72.17% -0.1%
+ Complexity 6684 6675 -9
===========================================
Files 637 637
Lines 27667 27677 +10
Branches 3332 3332
===========================================
- Hits 19994 19975 -19
- Misses 5925 5949 +24
- Partials 1748 1753 +5
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
===========================================
- Coverage 72.26% 72.17% -0.1%
+ Complexity 6684 6675 -9
===========================================
Files 637 637
Lines 27667 27677 +10
Branches 3332 3332
===========================================
- Hits 19994 19975 -19
- Misses 5925 5949 +24
- Partials 1748 1753 +5
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Dec 11, 2018
minwoox
approved these changes
Dec 11, 2018
hyangtack
approved these changes
Dec 11, 2018
|
Thanks for reviewing. |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: `InboundTrafficController` uses a hard-coded water mark value of 128KiB, which is much smaller than our current initial connection window size (1MiB). Modifications: - Use the water mark values that matches the initial HTTP/2 connection window size. - HTTP/1 connections' water mark values stay same. - Disable Netty `Channel` write buffer water mark to reduce unnecessary emission of `channelWritabilityChanged` events. Result: - Less frequent network read suspension which was unnecessary. - Less frequent `channelWritabilityChanged` events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
InboundTrafficControlleruses a hard-coded water mark value of 128KiB,which is much smaller than our current initial connection window size
(1MiB).
Modifications:
window size.
Channelwrite buffer water mark to reduce unnecessaryemission of
channelWritabilityChangedevents.Result:
channelWritabilityChangedevents.