New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize Consumer<ServerBuilder> beans for spring autoconfiguration #2070
Conversation
thanks so much for always sweeping up the feedback, Rag! |
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
============================================
- Coverage 73.79% 73.72% -0.07%
+ Complexity 9391 9387 -4
============================================
Files 817 817
Lines 36121 36124 +3
Branches 4452 4452
============================================
- Hits 26654 26632 -22
- Misses 7168 7189 +21
- Partials 2299 2303 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never knew that is possible. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…ine#2070) I think it's useful to be able to customize with spring without using custom types, for example to allow creating a plugin module that just configures a server without needing to worry about armeria-spring. It's sort of similar to how Spring supports both custom annotations and `javax.inject` annotaions. Idea came up in openzipkin-contrib/zipkin-storage-kafka#38
…ine#2070) I think it's useful to be able to customize with spring without using custom types, for example to allow creating a plugin module that just configures a server without needing to worry about armeria-spring. It's sort of similar to how Spring supports both custom annotations and `javax.inject` annotaions. Idea came up in openzipkin-contrib/zipkin-storage-kafka#38
I think it's useful to be able to customize with spring without using custom types, for example to allow creating a plugin module that just configures a server without needing to worry about armeria-spring. It's sort of similar to how Spring supports both custom annotations and
javax.inject
annotaions.Idea came up in openzipkin-contrib/zipkin-storage-kafka#38
/cc @adriancole @jeqo