Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Kotlin sample. #1880 #2128

Closed
wants to merge 1 commit into from

Conversation

@cnevinc
Copy link

cnevinc commented Sep 30, 2019

This commit transfer spring-boot-minimal into Kotlin.

@cnevinc cnevinc requested review from ikhoon, minwoox and trustin as code owners Sep 30, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Sep 30, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cnevinc cnevinc force-pushed the cnevinc:nevin/kotlin branch from a7717fd to 60cca59 Sep 30, 2019
This commit transfer `spring-boot-minimal` into Kotlin.
@cnevinc cnevinc force-pushed the cnevinc:nevin/kotlin branch from 60cca59 to 858f41b Oct 1, 2019
@ikhoon ikhoon added the documentation label Oct 1, 2019
@ikhoon ikhoon added this to the 0.94.0 milestone Oct 1, 2019
@ikhoon

This comment has been minimized.

Copy link
Contributor

ikhoon commented Oct 1, 2019

@cnevinc Thanks for contributing! I'm happy to review this PR. 😊
And could you sign CLA?

Copy link
Member

trustin left a comment

Thanks a lot for your contribution!

@@ -0,0 +1,46 @@
buildscript {
ext.kotlin_version = '1.3.50'

This comment has been minimized.

Copy link
@trustin

trustin Oct 1, 2019

Member

How about adding kotlin-stdlib-jdk8 to dependencies.yml and refer to the version via managedVersion?

@@ -55,6 +55,7 @@ includeWithFlags ':examples:grpc-service', 'java'
includeWithFlags ':examples:proxy-server', 'java'
includeWithFlags ':examples:saml-service-provider', 'java'
includeWithFlags ':examples:server-sent-events', 'java'
includeWithFlags ':examples:spring-boot-kotlin', 'java'

This comment has been minimized.

Copy link
@trustin

trustin Oct 1, 2019

Member

spring-boot-minimal-kotlin?

@trustin

This comment has been minimized.

Copy link
Member

trustin commented Oct 1, 2019

Could you also use the different package name with the spring-boot-minimal example? It seems like JaCoCo is confused. How about just add .kt to the package names?

import org.springframework.boot.autoconfigure.SpringBootApplication

@SpringBootApplication
open class Main {

This comment has been minimized.

Copy link
@heowc

heowc Oct 1, 2019

Contributor

Spring is guiding you to a better example than the change from java to kotlin function provided by idea.

Wouldn't this be more familiar to others?

@heowc

This comment has been minimized.

Copy link
Contributor

heowc commented Oct 1, 2019

Hello, Welcome to contribute code to Armeria! 😄

Although I don't know much about Kotlin, I saw the code and would like to suggest it.

Rather than just converting, I think that using the generator provided by start.spring.io will be an easier and more user-friendly example.

@trustin trustin modified the milestones: 0.94.0, 0.94.1 Oct 2, 2019
@cnevinc

This comment has been minimized.

Copy link
Author

cnevinc commented Oct 3, 2019

Rather than just converting, I think that using the generator provided by start.spring.io will be an easier and more user-friendly example.

Good idea. I'll come up with a better example in the other PR. Thank you!

@cnevinc cnevinc closed this Oct 3, 2019
@trustin

This comment has been minimized.

Copy link
Member

trustin commented Nov 15, 2019

@cnevinc Any news on a follow-up? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.