Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example:spring-boot-minimal-kotlin #2335

Merged
merged 7 commits into from Dec 27, 2019

Conversation

@heowc
Copy link
Contributor

heowc commented Dec 20, 2019

Related: #1078, #1880

Motivation:

  • An example is provided to users of Kotlin.

Modifications:

  • Make an example in Kotlin that looks like spring-boot-minimal.

Result:

  • Partial fix for #1880
  • User-friendliness
@heowc heowc requested review from ikhoon, minwoox and trustin as code owners Dec 20, 2019
@heowc

This comment has been minimized.

Copy link
Contributor Author

heowc commented Dec 20, 2019

PROFILE=java8

Caused by: java.lang.UnsupportedClassVersionError: example/springframework/boot/minimal/kotlin/HelloApplicationIntegrationTest has been compiled by a more recent version of the Java Runtime (class file version 56.0), this version of the Java Runtime only recognizes class file versions up to 52.0

PROFILE=java11

Caused by: java.lang.UnsupportedClassVersionError: example/springframework/boot/minimal/kotlin/HelloApplicationIntegrationTest has been compiled by a more recent version of the Java Runtime (class file version 56.0), this version of the Java Runtime only recognizes class file versions up to 55.0

I'm looking for a reason why the test fails in AppVeyor. 😦

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #2335 into master will increase coverage by <.01%.
The diff coverage is 72.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2335      +/-   ##
============================================
+ Coverage     73.64%   73.64%   +<.01%     
- Complexity    10311    10455     +144     
============================================
  Files           898      925      +27     
  Lines         39379    39889     +510     
  Branches       4895     4914      +19     
============================================
+ Hits          29002    29378     +376     
- Misses         7895     8013     +118     
- Partials       2482     2498      +16
Impacted Files Coverage Δ Complexity Δ
.../java/com/linecorp/armeria/common/HttpHeaders.java 46.87% <ø> (ø) 8 <0> (ø) ⬇️
...om/linecorp/armeria/common/logging/RequestLog.java 23.52% <ø> (ø) 8 <0> (ø) ⬇️
.../main/java/com/linecorp/armeria/common/Cookie.java 28.57% <ø> (ø) 22 <0> (ø) ⬇️
.../armeria/common/DefaultResponseHeadersBuilder.java 95% <ø> (ø) 9 <0> (ø) ⬇️
...linecorp/armeria/common/util/StartStopSupport.java 95.94% <ø> (ø) 52 <0> (ø) ⬇️
...ain/java/com/linecorp/armeria/client/Endpoint.java 94.52% <ø> (ø) 101 <0> (ø) ⬇️
...va/com/linecorp/armeria/common/HttpParameters.java 33.33% <ø> (ø) 3 <0> (ø) ⬇️
...om/linecorp/armeria/server/docs/TypeSignature.java 84.28% <ø> (-2.86%) 29 <0> (-1)
...ava/com/linecorp/armeria/server/file/HttpFile.java 58.33% <ø> (ø) 5 <0> (ø) ⬇️
...p/armeria/server/file/AbstractHttpFileBuilder.java 81.81% <ø> (ø) 22 <0> (ø) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b257f...5908d2b. Read the comment docs.

@heowc

This comment has been minimized.

Copy link
Contributor Author

heowc commented Dec 22, 2019

I didn't know to build only with JDK 12. (I thought it was building with each individual JDK in the AppVeyor.) So I had a problem with JavaVersion.current() being set to 12 only. 😳

This problem is a simple example provided to the user, so I think it's a good idea to fix it to 1.8 rather than modifying the various settings.

Note that JDK 13 is not supported.

Copy link
Member

minwoox left a comment

Thank you!

settings/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
@heowc

This comment has been minimized.

Copy link
Contributor Author

heowc commented Dec 24, 2019

I will revise the review later. 😊

🎄 Have a Merry Christmas!! 💝

settings.gradle Show resolved Hide resolved
Copy link
Member

trustin left a comment

Nice job, @heowc 👍

@ikhoon
ikhoon approved these changes Dec 26, 2019
Copy link
Contributor

ikhoon left a comment

Great work, This example could be a good tutorial for Kotlin users. 😀

@heowc

This comment has been minimized.

Copy link
Contributor Author

heowc commented Dec 26, 2019

Thanks for the passionate review of the new example! 😆

@trustin trustin added this to the 0.98.0 milestone Dec 27, 2019
@trustin trustin merged commit 2f55037 into line:master Dec 27, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 72.93% of diff hit (target 73.64%)
Details
codecov/project 73.64% (+<.01%) compared to 63b257f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@trustin

This comment has been minimized.

Copy link
Member

trustin commented Dec 27, 2019

Thanks, @heowc and reviewers! 🎉

@heowc heowc deleted the heowc:example_spring_boot_minimal_kotlin branch Dec 27, 2019
@trustin

This comment has been minimized.

Copy link
Member

trustin commented Dec 27, 2019

By the way, what about adding other Kotlin examples as well? 😉

@heowc heowc mentioned this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.