New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DocServiceConfigurator into boot2-webflux-autoconfigure #2960
Add DocServiceConfigurator into boot2-webflux-autoconfigure #2960
Conversation
472d9e9
to
c84c55d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2960 +/- ##
==========================================
Coverage 73.16% 73.17%
- Complexity 12208 12266 +58
==========================================
Files 1058 1060 +2
Lines 47373 47671 +298
Branches 5995 6018 +23
==========================================
+ Hits 34662 34884 +222
- Misses 9665 9736 +71
- Partials 3046 3051 +5 Continue to review full report at Codecov.
|
.../src/main/java/com/linecorp/armeria/spring/web/reactive/ArmeriaReactiveWebServerFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @matsumana. 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matsumana Gentle ping - We're gonna release a new version tomorrow morning 😉 |
Updated but #2960 (comment) is remaining. Sorry, I didn't notice the your comments immediately... |
Thanks a lot, @matsumana 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! @matsumana ❤️
Thank you guys for the review! |
This changeset fixes a bug where a user can't use `DocServiceConfigurator` in `boot2-webflux-autoconfigure`.
Hi.
Currently can't use DocServiceConfigurator in boot2-webflux-autoconfigure, so I'd like to add it.