Skip to content

Add DocServiceConfigurator into boot2-webflux-autoconfigure - #2960

Merged
trustin merged 3 commits into
line:masterfrom
matsumana:fix-DocServiceConfigurator-for-boot2-webflux-autoconfigure
Aug 4, 2020
Merged

Add DocServiceConfigurator into boot2-webflux-autoconfigure#2960
trustin merged 3 commits into
line:masterfrom
matsumana:fix-DocServiceConfigurator-for-boot2-webflux-autoconfigure

Conversation

@matsumana

Copy link
Copy Markdown
Member

Hi.
Currently can't use DocServiceConfigurator in boot2-webflux-autoconfigure, so I'd like to add it.

@CLAassistant

CLAassistant commented Aug 1, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@matsumana
matsumana force-pushed the fix-DocServiceConfigurator-for-boot2-webflux-autoconfigure branch from 472d9e9 to c84c55d Compare August 1, 2020 17:59
@codecov

codecov Bot commented Aug 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2960 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #2960    +/-   ##
==========================================
  Coverage     73.16%   73.17%            
- Complexity    12208    12266    +58     
==========================================
  Files          1058     1060     +2     
  Lines         47373    47671   +298     
  Branches       5995     6018    +23     
==========================================
+ Hits          34662    34884   +222     
- Misses         9665     9736    +71     
- Partials       3046     3051     +5     
Impacted Files Coverage Δ Complexity Δ
.../web/reactive/ArmeriaReactiveWebServerFactory.java 75.78% <100.00%> (+3.55%) 23.00 <1.00> (+4.00)
...a/common/grpc/protocol/ArmeriaStatusException.java 57.14% <0.00%> (-42.86%) 2.00% <0.00%> (-1.00%)
...linGrpc/example/armeria/grpc/kotlin/HelloGrpcKt.kt 82.81% <0.00%> (-6.22%) 0.00% <0.00%> (ø%)
...armeria/internal/common/grpc/HttpStreamReader.java 79.77% <0.00%> (-4.75%) 25.00% <0.00%> (-1.00%)
.../armeria/client/endpoint/dns/DnsEndpointGroup.java 76.56% <0.00%> (-4.69%) 12.00% <0.00%> (-3.00%)
...ria/common/grpc/protocol/ArmeriaMessageFramer.java 90.76% <0.00%> (-2.89%) 25.00% <0.00%> (ø%)
.../linecorp/armeria/client/DefaultClientFactory.java 64.51% <0.00%> (-2.16%) 27.00% <0.00%> (-1.00%)
.../com/linecorp/armeria/server/docs/ServiceInfo.java 78.94% <0.00%> (-1.76%) 20.00% <0.00%> (-1.00%)
...om/linecorp/armeria/client/HttpClientDelegate.java 98.33% <0.00%> (-1.67%) 35.00% <0.00%> (+5.00%) ⬇️
.../com/linecorp/armeria/server/RoutingPredicate.java 69.35% <0.00%> (-1.62%) 20.00% <0.00%> (-1.00%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633a70c...9e5a3af. Read the comment docs.

@ikhoon ikhoon added the defect label Aug 3, 2020
@ikhoon ikhoon added this to the 0.99.9 milestone Aug 3, 2020

@minwoox minwoox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @matsumana. 🙇‍♂️

Comment thread spring/boot2-webflux-autoconfigure/build.gradle

@trustin trustin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comments from @ikhoon and @minwoox are all addressed. 🙇

@trustin

trustin commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

@matsumana Gentle ping - We're gonna release a new version tomorrow morning 😉

@matsumana

matsumana commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

Updated but #2960 (comment) is remaining.

Sorry, I didn't notice the your comments immediately...
Could you exclude this PR from the new release, if I can't meet the deadline?

@trustin
trustin merged commit b321d90 into line:master Aug 4, 2020
@trustin

trustin commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Thanks a lot, @matsumana 🙇

@ikhoon ikhoon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! @matsumana ❤️

@matsumana

Copy link
Copy Markdown
Member Author

Thank you guys for the review!

@matsumana
matsumana deleted the fix-DocServiceConfigurator-for-boot2-webflux-autoconfigure branch August 4, 2020 03:51
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
This changeset fixes a bug where a user can't use `DocServiceConfigurator` in `boot2-webflux-autoconfigure`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants