-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to reject any unintended parameters in multipart request. #5569
base: main
Are you sure you want to change the base?
Commits on May 17, 2024
-
Fix to reject any unintended parameters in multipart request.
Motivation: this resolves line#5549 Modifications: - Fix(AnnotatedServiceMultipartTest): Add test for upload multipart file with unexpected parameters in AnnotatedServiceMultipartTest. - Fix(AnnotatedService): Fix to include a list of intended parameters in the ServiceRequestContext. - Fix(FileAggregatedMultipart): Fix to check if any variables are passed in the list of intended parameters and throw an acceptance if not. Result: Multipart requests with unintended parameters will no longer create files.
Configuration menu - View commit details
-
Copy full SHA for 291d8a3 - Browse repository at this point
Copy the full SHA 291d8a3View commit details -
Fix to use parameter lists instead of putting parameters in the Servi…
…ceRequestContext
Configuration menu - View commit details
-
Copy full SHA for ed23db1 - Browse repository at this point
Copy the full SHA ed23db1View commit details
Commits on May 27, 2024
-
Update core/src/main/java/com/linecorp/armeria/internal/server/annota…
…tion/DefaultAnnotatedService.java Co-authored-by: minux <songmw725@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 30c20f0 - Browse repository at this point
Copy the full SHA 30c20f0View commit details
Commits on Jun 19, 2024
-
Change to elegant exception handling
Motivation: If an unintended file was entered, it threw an exception and terminated. This behavior was frustrating to the user, so changed to a calmer method that simply ignores the file. Modification: - Fix(AnnotatedServiceMultipartTest): Change from BAD REQUEST to OK, and change the file name to be more distinguishable. - Fix(FileAggregatedMultipart): Add filtering - Fix(Multipart): Add filtering. I wanted to name the filtering method filter, but because the StreamMessage interface already has a filter function, and because the DefaultMultipart class implements both the multipart interface and the StreamMessage interface, I used a different name. Result: It no longer raises an acceptance. Instead, unintended files are filtered out before they are written to disk.
Configuration menu - View commit details
-
Copy full SHA for ad2c7e7 - Browse repository at this point
Copy the full SHA ad2c7e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a79b95 - Browse repository at this point
Copy the full SHA 9a79b95View commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f3e68f1 - Browse repository at this point
Copy the full SHA f3e68f1View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3f4eb6a - Browse repository at this point
Copy the full SHA 3f4eb6aView commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2543a9c - Browse repository at this point
Copy the full SHA 2543a9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0497cd4 - Browse repository at this point
Copy the full SHA 0497cd4View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cdb1549 - Browse repository at this point
Copy the full SHA cdb1549View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f4b6a - Browse repository at this point
Copy the full SHA f2f4b6aView commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6201c4 - Browse repository at this point
Copy the full SHA c6201c4View commit details
Commits on Sep 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c18bea1 - Browse repository at this point
Copy the full SHA c18bea1View commit details
Commits on Sep 17, 2024
-
Since the request is processed and the file is deleted, change to testing with the response value
Configuration menu - View commit details
-
Copy full SHA for 356f7ef - Browse repository at this point
Copy the full SHA 356f7efView commit details -
Merge branch 'armeria-5549' of https://github.com/Bue-von-hon/armeria …
…into armeria-5549
Configuration menu - View commit details
-
Copy full SHA for b2683d3 - Browse repository at this point
Copy the full SHA b2683d3View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e9c7f6 - Browse repository at this point
Copy the full SHA 0e9c7f6View commit details