Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to reject any unintended parameters in multipart request. #5569

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Commits on May 17, 2024

  1. Fix to reject any unintended parameters in multipart request.

    Motivation:
    this resolves line#5549
    
    Modifications:
    - Fix(AnnotatedServiceMultipartTest): Add test for upload multipart file with unexpected parameters in AnnotatedServiceMultipartTest.
    - Fix(AnnotatedService): Fix to include a list of intended parameters in the ServiceRequestContext.
    - Fix(FileAggregatedMultipart): Fix to check if any variables are passed in the list of intended parameters and throw an acceptance if not.
    
    Result:
    Multipart requests with unintended parameters will no longer create files.
    Bue-von-hon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    291d8a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed23db1 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Update core/src/main/java/com/linecorp/armeria/internal/server/annota…

    …tion/DefaultAnnotatedService.java
    
    Co-authored-by: minux <songmw725@gmail.com>
    Bue-von-hon and minwoox committed May 27, 2024
    Configuration menu
    Copy the full SHA
    30c20f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Change to elegant exception handling

    Motivation:
    If an unintended file was entered, it threw an exception and terminated. This behavior was frustrating to the user, so changed to a calmer method that simply ignores the file.
    
    Modification:
    - Fix(AnnotatedServiceMultipartTest): Change from BAD REQUEST to OK, and change the file name to be more distinguishable.
    - Fix(FileAggregatedMultipart): Add filtering
    - Fix(Multipart): Add filtering. I wanted to name the filtering method filter,
                      but because the StreamMessage interface already has a filter function,
                      and because the DefaultMultipart class implements both the multipart interface and the StreamMessage interface,
                      I used a different name.
    
    Result:
    It no longer raises an acceptance. Instead, unintended files are filtered out before they are written to disk.
    Bue-von-hon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ad2c7e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a79b95 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    f3e68f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Resolves code review

    Bue-von-hon committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3f4eb6a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    2543a9c View commit details
    Browse the repository at this point in the history
  2. Fix lint

    Bue-von-hon committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0497cd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    cdb1549 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2f4b6a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    c6201c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Configuration menu
    Copy the full SHA
    c18bea1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Fixing broken test

    Since the request is processed and the file is deleted, change to testing with the response value
    Bue-von-hon committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    356f7ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2683d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    0e9c7f6 View commit details
    Browse the repository at this point in the history