Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the path to Central Dogma bin directory to PATH environment variable #307

Merged
merged 1 commit into from Nov 12, 2018

Conversation

@matsumana
Copy link
Contributor

@matsumana matsumana commented Nov 11, 2018

I think it's more helpful for the bin directory to be added to the PATH environment variable, when trying the official documentation's Command-line client examples with Docker.

As-Is

root@59898138fb3a:/# dogma -v
bash: dogma: command not found

To-Be

root@66eda13670d0:/# dogma -v
Central Dogma version 0.32.2-SNAPSHOT (d0f922e)
@matsumana matsumana requested review from hyangtack, minwoox and trustin as code owners Nov 11, 2018
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Nov 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

@codecov codecov bot commented Nov 11, 2018

Codecov Report

Merging #307 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   65.62%   65.53%   -0.09%     
==========================================
  Files         280      280              
  Lines       10259    10259              
  Branches     1143     1143              
==========================================
- Hits         6732     6723       -9     
- Misses       2879     2888       +9     
  Partials      648      648
Impacted Files Coverage Δ
.../centraldogma/internal/client/AbstractWatcher.java 62.22% <0%> (-7.41%) ⬇️
...internal/replication/ZooKeeperCommandExecutor.java 77.74% <0%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2e9cf...169ffc2. Read the comment docs.

@trustin trustin added the defect label Nov 12, 2018
@trustin trustin added this to the 0.33.0 milestone Nov 12, 2018
@trustin
Copy link
Collaborator

@trustin trustin commented Nov 12, 2018

Thank you!

Copy link
Member

@minwoox minwoox left a comment

Thanks a lot~!

@trustin trustin merged commit b9917fd into line:master Nov 12, 2018
5 checks passed
5 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch Coverage not affected when comparing 5f9b585...169ffc2
Details
@codecov
codecov/project 65.53% (-0.09%) compared to 5f9b585
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants