Add AccountLink event #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugyan
reviewed
Jul 12, 2018
linebot/event.go
Outdated
| Message Message | ||
| Postback *Postback | ||
| Beacon *Beacon | ||
| AccountLink *AccountLink `json:"link"` |
There was a problem hiding this comment.
Oh, sorry. This tag is not needed.
linebot/event.go
Outdated
| @@ -82,25 +83,33 @@ type Beacon struct { | |||
| DeviceMessage []byte | |||
| } | |||
|
|
|||
| // AccountLink type | |||
| type AccountLink struct { | |||
| Result string | |||
There was a problem hiding this comment.
Result seems to be ok or failed only.
Can you modify its type from string to other type and use constant values?
For example:
type AccountLinkResult string
const (
AccountLinkResultOK AccountLinkResult = "ok"
AccountLinkResultFailed AccountLinkResult = "failed"
)
There was a problem hiding this comment.
Thank you for your review. I see.
I will fix them and add tests of Event.MarshalJSON and Event.UnmarshalJSON.
And I have to fix Event.MarshalJSON also.
|
I have fixed. |
sugyan
reviewed
Jul 12, 2018
linebot/webhook_test.go
Outdated
| @@ -236,6 +236,19 @@ var webhookTestRequestBody = `{ | |||
| "type":"enter", | |||
| "dm":"1234567890abcdef" | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Could you please replace tabs to spaces...? (Here is just inside the JSON literal..)
linebot/webhook_test.go
Outdated
| UserID: "U012345678901234567890123456789ab", | ||
| }, | ||
| AccountLink: &AccountLink{ | ||
| Result: "ok", |
There was a problem hiding this comment.
Maybe Result: AccountLinkResultOK is more better.
|
@sugyan Thank you for your review. |
|
LGTM. Thanks! 🙆♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.