Initialize v2 API#731
Merged
Merged
Conversation
hoangpn
force-pushed
the
feature/v2_api
branch
3 times, most recently
from
66aeec4 to
3104318
Compare
vincent-olivert-riera
previously approved these changes
May 21, 2026
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Just a minor thing about the rapidoc script import.
Everything else looks fine to me.
Comment on lines
+69
to
+70
| <script src="{% static 'js/promgen.vue.js' %}?v=7"></script> | ||
| <script type="module" src="{% static 'js/rapidoc.min.js' %}" integrity="sha384-rpBuyGgeMsj+36JZKKBL7CBL9FIcPWbyA3YBRJZEAa37nT1P8rxUl/s9EwJE6zSE" crossorigin="anonymous"></script> |
Contributor
There was a problem hiding this comment.
Same as we did for VueJS, could you please store the rapidoc.min.js file inside its own directory with the version on its name? For instance js/rapidoc-9.3.8/rapidoc.min.js.
Also, better format this line:
<script
type="module"
src="{% static 'js/rapidoc-9.3.8/rapidoc.min.js' %}"
integrity="sha384-rpBuyGgeMsj+36JZKKBL7CBL9FIcPWbyA3YBRJZEAa37nT1P8rxUl/s9EwJE6zSE"
crossorigin="anonymous"
></script>
vincent-olivert-riera
requested changes
May 21, 2026
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
You need to leave a comment indicating the requested changes.
🤷
We have added basic settings aimed at supporting the development of Promgen's v2 API. Summary: - A new router has been created. New APIs will have the prefix /rest/v2 in the endpoint and belong to the api-v2 namespace. - A dedicated View for documenting the new APIs is implemented using drf-spectacular and RapiDoc. - The API Schema is generated according to the OpenAPI 3.0 standard. - PromgenPagination class is created to support paginated responses. - PromgenGuardianRestPermission class is added to serve per-object permission checks with logic similar to Promgen Web.
We have added a new API for retrieving and filtering Audit Log data.
Contributor
Author
|
@vincent-olivert-riera |
vincent-olivert-riera
approved these changes
May 21, 2026
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to initialize the development of Promgen's v2 API.
Summary: