Skip to content

Conversation

@vim-zz
Copy link
Collaborator

@vim-zz vim-zz commented Sep 1, 2025

Note how to use async plugins in gitStream condition clauses with immediate: true flag and the implications for optimization and API calls

https://linearb.atlassian.net/browse/LINBEE-18998

Screenshot 2025-09-01 at 9 45 45

✨ PR Description

Purpose: Add documentation for using asynchronous plugins in conditions by explaining the need for the 'immediate: true' flag to prevent optimization issues.

Main changes:

  • Added section explaining how async plugins need 'immediate: true' flag in conditions
  • Included code example demonstrating proper async plugin configuration
  • Added YAML example showing proper usage pattern in automation rules

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Note how to use async plugins in gitStream condition clauses with
immediate: true flag and the implications for optimization and API calls
@vim-zz vim-zz requested a review from MishaKav September 1, 2025 06:47
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR adds documentation on using async plugins in condition clauses with the immediate: true flag, clarifying optimization behavior and side effects. The content is generally clear, but there are a couple of correctness and formatting issues to address.

2 issues detected:

🐞 Bug - Invalid language specifier "yaml+jinja" in code fence can lead to improper rendering.

Details: The code block for the YAML+Jinja example is fenced with an invalid language identifier "yaml+jinja", which may break syntax highlighting or rendering in some markdown processors used for the docs site.
File: docs/plugins-for-developers.md (85-85)

🧾 Readability - Vague description reduces clarity for users diagnosing issues.

Details: The phrase "plugin to not work properly" is vague; it would help readers to specify the observable behavior (e.g., condition always false, plugin not invoked) to set correct expectations and aid troubleshooting.
File: docs/plugins-for-developers.md (71-71)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀


The `immediate: true` flag tells the system not to optimize plugin execution. The downside is that the plugin might be called multiple times during the workflow execution. If your plugin makes API calls, this will result in multiple API requests as well.

```yaml+jinja
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 Bug - Markdown Fence Typo: Change the code fence language from yaml+jinja to a supported identifier such as jinja or ```yaml, or configure the docs engine accordingly.

Suggested change
```yaml+jinja
```jinja

@gitstream-cm gitstream-cm bot requested a review from a team September 1, 2025 06:48
gitstream-cm[bot]
gitstream-cm bot previously approved these changes Sep 1, 2025
@gitstream-cm gitstream-cm bot requested a review from a team September 1, 2025 06:48
Copy link
Collaborator

@MishaKav MishaKav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@gitstream-cm
Copy link
Contributor

gitstream-cm bot commented Sep 1, 2025

A screenshot of the relevant part of docs after the changes is a life saver 🛟

@gitstream-cm gitstream-cm bot requested a review from a team September 1, 2025 06:49
@gitstream-cm gitstream-cm bot dismissed their stale review September 1, 2025 06:49

Review dismissed

@vim-zz vim-zz merged commit 12fddc1 into main Sep 1, 2025
15 checks passed
@vim-zz vim-zz deleted the add-async-plugin-condition branch September 1, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants