-
Notifications
You must be signed in to change notification settings - Fork 45
Update PR creation and ready-for-review trigger defaults #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR updates trigger default behaviors in documentation, changing PR creation to only trigger for non-draft PRs and enabling the ready-for-review transition trigger.
1 issues detected:
🧾 Readability - Inconsistent capitalization pattern breaks documentation formatting consistency.
Details: The condition "When not a draft" uses inconsistent capitalization compared to other conditional entries in the table which use lowercase "when".
File:docs/execution-model.md (72-72)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
docs/execution-model.md
Outdated
| | :fontawesome-brands-github: Comment edited | - | when `pr.comment` in `.cm` | | ||
| | Commit pushed | `commit` | `on` | | ||
| | Creating a PR | `pr_created` | `on` | | ||
| | Creating a PR | `pr_created` | When not a draft | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧾 Readability - Inconsistent Capitalization: Change "When not a draft" to "when not a draft" to maintain consistency with other conditional entries in the table.
| | Creating a PR | `pr_created` | When not a draft | | |
| | Creating a PR | `pr_created` | when not a draft | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gs feedback its correct but I dont care about it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
MishaKav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeelali14 FYI
✨ PR Description
Purpose: Update PR trigger defaults documentation to clarify that PR ready-for-review trigger is enabled by default.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀