Skip to content

Conversation

@vim-zz
Copy link
Collaborator

@vim-zz vim-zz commented Oct 20, 2025

Screenshot 2025-10-20 at 11 51 31

✨ PR Description

Purpose: Update PR trigger defaults documentation to clarify that PR ready-for-review trigger is enabled by default.

Main changes:

  • Changed trigger table format by adding a "Conditions" column for improved readability
  • Updated PR ready-for-review trigger status from "off" to "on" by default
  • Adjusted table column width in CSS to accommodate the new column structure

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR updates trigger default behaviors in documentation, changing PR creation to only trigger for non-draft PRs and enabling the ready-for-review transition trigger.

1 issues detected:

🧾 Readability - Inconsistent capitalization pattern breaks documentation formatting consistency.

Details: The condition "When not a draft" uses inconsistent capitalization compared to other conditional entries in the table which use lowercase "when".
File: docs/execution-model.md (72-72)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

| :fontawesome-brands-github: Comment edited | - | when `pr.comment` in `.cm` |
| Commit pushed | `commit` | `on` |
| Creating a PR | `pr_created` | `on` |
| Creating a PR | `pr_created` | When not a draft |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧾 Readability - Inconsistent Capitalization: Change "When not a draft" to "when not a draft" to maintain consistency with other conditional entries in the table.

Suggested change
| Creating a PR | `pr_created` | When not a draft |
| Creating a PR | `pr_created` | when not a draft |

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gs feedback its correct but I dont care about it here

@gitstream-cm gitstream-cm bot requested a review from a team October 20, 2025 08:37
gitstream-cm[bot]
gitstream-cm bot previously approved these changes Oct 20, 2025
Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@gitstream-cm gitstream-cm bot dismissed their stale review October 20, 2025 08:54

Review dismissed

Copy link
Collaborator

@MishaKav MishaKav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstream-cm gitstream-cm bot requested a review from a team October 20, 2025 10:40
@vim-zz vim-zz merged commit 52cd82c into main Oct 20, 2025
11 checks passed
@vim-zz vim-zz deleted the fix-triggers-definitions branch October 20, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants