Skip to content

Allow passing --link to add links to a release#92

Merged
RomainCscn merged 1 commit into
mainfrom
romain/lin-71118-add-flag-to-add-link-to-release-to-sync
May 21, 2026
Merged

Allow passing --link to add links to a release#92
RomainCscn merged 1 commit into
mainfrom
romain/lin-71118-add-flag-to-add-link-to-release-to-sync

Conversation

@RomainCscn
Copy link
Copy Markdown
Collaborator

@RomainCscn RomainCscn commented May 20, 2026

Should be merged after https://github.com/linear/linear-app/pull/75383 (API).

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 20, 2026

LIN-71118

Copy link
Copy Markdown

@linear-code linear-code Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The feature is well-scoped — parsing is correct (bare URLs go through parseHttpUrl before the = split, so query-string = signs in bare URLs are handled safely), all three mutations pass links via GraphQL variables (not string interpolation), and the null→undefined coercion for commitSha is handled at the call site. No blocking issues.

@RomainCscn RomainCscn force-pushed the romain/lin-71118-add-flag-to-add-link-to-release-to-sync branch from 3811315 to c3f7b68 Compare May 21, 2026 08:04
Base automatically changed from romain/lin-71182-first-sync-issue-override-the-initial-sha to main May 21, 2026 08:35
@RomainCscn RomainCscn force-pushed the romain/lin-71118-add-flag-to-add-link-to-release-to-sync branch 3 times, most recently from cd5080d to ecf1caf Compare May 21, 2026 09:19
@RomainCscn RomainCscn force-pushed the romain/lin-71118-add-flag-to-add-link-to-release-to-sync branch from ecf1caf to e3843d6 Compare May 21, 2026 09:38
@RomainCscn RomainCscn merged commit 1ae492d into main May 21, 2026
10 checks passed
@RomainCscn RomainCscn deleted the romain/lin-71118-add-flag-to-add-link-to-release-to-sync branch May 21, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants