Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add freebsd target #2249

Merged
merged 4 commits into from
Sep 18, 2022
Merged

add freebsd target #2249

merged 4 commits into from
Sep 18, 2022

Conversation

nunotexbsd
Copy link
Contributor

add freebsd target for lapce freebsd port
lapce/lapce#985

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Aug 31, 2022
@nunotexbsd
Copy link
Contributor Author

Hi,

Can't understand why checks are failing by adding freebsd target. It builds fine in freebsd.
Any hints on how to fix this?

Thanks

@jneem
Copy link
Collaborator

jneem commented Sep 12, 2022

In the logs for cargo clippy+test (ubuntu-latest), it's failing on some missing imports. Maybe they're cfged out somehow?

@nunotexbsd
Copy link
Contributor Author

I did this changes manually so maybe something is missing.
Is there a possibility of replacing openbsd with freebsd targets for testing purposes?

freebsd target was merged in lapce/lapce#985 and lapce is running fine with freebsd patched druid at https://www.freshports.org/editors/lapce/

druid-shell/src/backend/shared/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Jakub Panek <me@panekj.dev>
@nunotexbsd
Copy link
Contributor Author

In the logs for cargo clippy+test (ubuntu-latest), it's failing on some missing imports. Maybe they're cfged out somehow?

@jneem I did understanded @panekj sugestion changes and it fixed almost all tests.
I've checked cargo fmt build log but I don't see what can be done here because I don't see a more detailed error.

Any hint?

Thanks

@panekj
Copy link
Contributor

panekj commented Sep 14, 2022

just need cargo fmt on the code and it should be fine

@nunotexbsd
Copy link
Contributor Author

nunotexbsd commented Sep 14, 2022

nice!

just need cargo fmt on the code and it should be fine

So I must wait that someone include that code or it should be included at this point[1]?

[1] how to include it in code?

Thanks!

@panekj
Copy link
Contributor

panekj commented Sep 14, 2022

On your branch run cargo fmt and commit the code

@nunotexbsd
Copy link
Contributor Author

Done!

Thanks @panekj!

@jneem jneem merged commit 3160b5c into linebender:master Sep 18, 2022
liias pushed a commit to Browsers-software/druid that referenced this pull request Sep 20, 2022
Co-authored-by: Jakub Panek <me@panekj.dev>
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants