Alternative strategies for elements barrier #121
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides an #ifdef METAL for switching between two different
strategies for the barriers in the elements shader. With it enabled, the
barriers are in workgroup uniform control flow, which is compatible with
translation to Metal, but fails to compile in FXC, as FXC's uniformity
analysis fails. With it disabled, the lookback logic (including
barriers) runs only in a single thread, which compiles in FXC (though
not tested), but creates problems in Metal.
In testing on Android, the METAL version seems slightly faster. On AMD
5700 XT, there is no measurable difference.
I'm inclined not to commit this, but it's potentially useful if we want
to explore cs_5_0 compatibility.