Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String filter dialog checkbox does not behave as expected #237

Closed
oltionchampari opened this issue Feb 5, 2020 · 3 comments · Fixed by #274
Closed

String filter dialog checkbox does not behave as expected #237

oltionchampari opened this issue Feb 5, 2020 · 3 comments · Fixed by #274
Assignees
Labels
lineup: v4 All issues related to LineUp v4 status: help wanted Extra attention is needed type: bug Something isn't working
Projects

Comments

@oltionchampari
Copy link
Contributor

oltionchampari commented Feb 5, 2020

The string filter dialog allows you to press the filter rows containing empty values checkbox even though the use regular expression checkbox is already checked.

stringColumn.gif

Expected behavior:
The filter rows containing empty values checkbox should be disabled.

@oltionchampari oltionchampari added lineup: v3 All issues related to LineUp v3 lineup: v4 All issues related to LineUp v4 release: patch PR merge results in a new patch version type: bug Something isn't working labels Feb 5, 2020
@thinkh thinkh removed the release: patch PR merge results in a new patch version label Feb 10, 2020
@sgratzl sgratzl self-assigned this Feb 19, 2020
@sgratzl
Copy link
Member

sgratzl commented Feb 19, 2020

so far the filter logic / hierarchy is:

is filter missing checked?
  then -> filter for missing values
  else
    is the filter field empty?
      then -> no filtering
      else 
         is regex checked
         then -> interpret filter as regex
         else -> interpret as string filter

Thus atm when the user toggles the filter missing checkbox the input field + as regex is disabled. However, checking as regex doesn't influence whether the user can check the filter missing, since former just customizes the behavior of the search field.
4. else ->

@sgratzl sgratzl added the status: help wanted Extra attention is needed label Feb 19, 2020
@sgratzl sgratzl added this to New Issues in lineup Mar 20, 2020
@sgratzl sgratzl moved this from New Issues to Discussion / Waiting in lineup Mar 20, 2020
@thinkh
Copy link
Member

thinkh commented Mar 23, 2020

In my opinion the filter for string columns should work analog to the filter of numercial und categorical columns where users can filter for specific categories or ranges AND filter out missing values. At the end the checkbox filter missing values should be independent from the input field and checkbox above.

lineup-filter-missing-string

@sgratzl Is it possible to implement it like this?

@thinkh
Copy link
Member

thinkh commented Mar 23, 2020

I remove the lineup: v3 label, as the implementation for v4 is sufficient.

@thinkh thinkh added status: help wanted Extra attention is needed and removed lineup: v3 All issues related to LineUp v3 status: help wanted Extra attention is needed labels Mar 23, 2020
sgratzl added a commit that referenced this issue Mar 25, 2020
@sgratzl sgratzl linked a pull request Mar 25, 2020 that will close this issue
4 tasks
@sgratzl sgratzl closed this as completed Mar 25, 2020
lineup automation moved this from Discussion / Waiting to Done Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lineup: v4 All issues related to LineUp v4 status: help wanted Extra attention is needed type: bug Something isn't working
Projects
No open projects
lineup
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants