Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular expression based text filter bug #199

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Regular expression based text filter bug #199

merged 2 commits into from
Nov 8, 2019

Conversation

oltionchampari
Copy link
Contributor

@oltionchampari oltionchampari commented Oct 31, 2019 •
edited by thinkh

closes #197

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

Before:
before

After:
after

@oltionchampari oltionchampari added the type: bug Something isn't working label Oct 31, 2019
@thinkh thinkh added the lineup: v3 All issues related to LineUp v3 label Oct 31, 2019
thinkh
thinkh requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oltionchampari Please use the strict null check with ===, if possible.

src/model/StringColumn.ts Outdated Show resolved Hide resolved
@thinkh thinkh changed the base branch from master to develop November 8, 2019 11:35
@thinkh thinkh added the release: patch PR merge results in a new patch version label Nov 8, 2019
@thinkh thinkh merged commit ba19207 into develop Nov 8, 2019
@thinkh thinkh deleted the ochampari/197_regular_expression_based_text_filter_bug__lineup3 branch November 8, 2019 12:25
@thinkh thinkh mentioned this pull request Jan 16, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@sgratzl sgratzl Awaiting requested review from sgratzl

Assignees

@sgratzl sgratzl

@thinkh thinkh

Labels
lineup: v3 All issues related to LineUp v3 release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oltionchampari @sgratzl @thinkh