From c2a97bfa2f6229219226c97c2a47dbb353f544a0 Mon Sep 17 00:00:00 2001 From: Docs Action Bot Date: Tue, 17 Jun 2025 20:03:08 +0000 Subject: [PATCH 1/2] Update MLIR dialect documentation --- .../MLIR/Dialects/Arrow/ArrowDialect.md | 30 ++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/docs/ForDevelopers/MLIR/Dialects/Arrow/ArrowDialect.md b/docs/ForDevelopers/MLIR/Dialects/Arrow/ArrowDialect.md index 2a54289..fb77d09 100644 --- a/docs/ForDevelopers/MLIR/Dialects/Arrow/ArrowDialect.md +++ b/docs/ForDevelopers/MLIR/Dialects/Arrow/ArrowDialect.md @@ -23,7 +23,11 @@ operation ::= `arrow.array.is_valid` $array `,` $offset attr-dict ``` -Interfaces: `InferTypeOpInterface` +Traits: `AlwaysSpeculatableImplTrait` + +Interfaces: `ConditionallySpeculatable`, `InferTypeOpInterface`, `NoMemoryEffect (MemoryEffectOpInterface)` + +Effects: `MemoryEffects::Effect{}` #### Operands: @@ -52,7 +56,11 @@ operation ::= `arrow.array.load_bool` $array `,` $offset attr-dict This special operation is necessary, since Arrow stores boolean values as bitset, and not individual bytes. -Interfaces: `InferTypeOpInterface` +Traits: `AlwaysSpeculatableImplTrait` + +Interfaces: `ConditionallySpeculatable`, `InferTypeOpInterface`, `NoMemoryEffect (MemoryEffectOpInterface)` + +Effects: `MemoryEffects::Effect{}` #### Operands: @@ -82,6 +90,12 @@ operation ::= `arrow.array.load_fixed_sized` $array `,` $offset `->` type($value Used for loading types that are of fixed size from an arrow array (e.g., integers, floats, decimals, dates, timestamp). There are now runtime checks to ensure that the type of the value matches the type of the array, so this operation can be used for any fixed sized type. +Traits: `AlwaysSpeculatableImplTrait` + +Interfaces: `ConditionallySpeculatable`, `NoMemoryEffect (MemoryEffectOpInterface)` + +Effects: `MemoryEffects::Effect{}` + #### Operands: | Operand | Description | @@ -110,7 +124,11 @@ operation ::= `arrow.array.load_variable_size_binary` $array `,` $offset `->` ty Used for loading variable sized binary values from an arrow array (e.g., strings, binary data). It returns both a pointer to the data and the length of the data. -Interfaces: `InferTypeOpInterface` +Traits: `AlwaysSpeculatableImplTrait` + +Interfaces: `ConditionallySpeculatable`, `InferTypeOpInterface`, `NoMemoryEffect (MemoryEffectOpInterface)` + +Effects: `MemoryEffects::Effect{}` #### Operands: @@ -209,7 +227,11 @@ operation ::= `arrow.array_builder.from_ptr` $ptr `->` type($builder) attr-dict ``` -Interfaces: `InferTypeOpInterface` +Traits: `AlwaysSpeculatableImplTrait` + +Interfaces: `ConditionallySpeculatable`, `InferTypeOpInterface`, `NoMemoryEffect (MemoryEffectOpInterface)` + +Effects: `MemoryEffects::Effect{}` #### Operands: From 5cb3164ddc0e9b38637fa54bc4162e99e7af6b5a Mon Sep 17 00:00:00 2001 From: Docs Action Bot Date: Sat, 28 Jun 2025 09:23:41 +0000 Subject: [PATCH 2/2] Update MLIR dialect documentation --- .../MLIR/Dialects/SubOperator/SubOperatorDialect.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/ForDevelopers/MLIR/Dialects/SubOperator/SubOperatorDialect.md b/docs/ForDevelopers/MLIR/Dialects/SubOperator/SubOperatorDialect.md index ddccebb..fc262d3 100644 --- a/docs/ForDevelopers/MLIR/Dialects/SubOperator/SubOperatorDialect.md +++ b/docs/ForDevelopers/MLIR/Dialects/SubOperator/SubOperatorDialect.md @@ -496,7 +496,7 @@ Effects: `MemoryEffects::Effect{}` ### `subop.gather` (::lingodb::compiler::dialect::subop::GatherOp) -_Scatter_ +_Gather_ Syntax: @@ -806,6 +806,8 @@ Interfaces: `InferTypeOpInterface`, `StateUsingSubOperator`, `SubOperator` _Performs a lookup in a state and annotates the result as attribute_ +Currently LookupOp returns an optional reference when the state is a map structure. +It is therefore necessary to combine it with an UnwrapOptionalRefOp Interfaces: `InferTypeOpInterface`, `ReferenceProducer`, `StateUsingSubOperator`, `SubOperator`