Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close html list element when using Bootstrap 3 #23

Merged
merged 2 commits into from Jul 13, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 1, 2014

  • When the Bootstrap 3 flag is set, a <ul> tag is opened rather than a <div>. This also needs to be closed at the end.

Fixes #22

fofr added 2 commits Jul 1, 2014
* When the bootstrap 3 flag is set, a `<ul>` tag is opened rather than
a `<div>`. This also needs to be closed at the end.
fofr added a commit to alphagov/signon that referenced this pull request Jul 1, 2014
* Refer to fixed git branch of alphabetical_paginate in gem file
* Pull request outstanding:
lingz/alphabetical_paginate#23
* There’s an unclosed <ul> which causes incorrect nesting, and warning
when tests run.
fofr added a commit to alphagov/signon that referenced this pull request Jul 3, 2014
* Refer to fixed git branch of alphabetical_paginate in gem file
* Pull request outstanding:
lingz/alphabetical_paginate#23
* There’s an unclosed <ul> which causes incorrect nesting, and warning
when tests run.
fofr added a commit to alphagov/signon that referenced this pull request Jul 3, 2014
* Refer to fixed git branch of alphabetical_paginate in gem file
* Pull request outstanding:
lingz/alphabetical_paginate#23
* There’s an unclosed <ul> which causes incorrect nesting, and warning
when tests run.
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 10, 2014

Any movement on this?

@lingz
Copy link
Owner

@lingz lingz commented Jul 13, 2014

Sorry have been very busy as of late! I'll merge and release now!

@lingz lingz closed this Jul 13, 2014
@lingz lingz reopened this Jul 13, 2014
lingz added a commit that referenced this pull request Jul 13, 2014
Close html list element when using Bootstrap 3
@lingz lingz merged commit dc01d53 into lingz:master Jul 13, 2014
@lingz
Copy link
Owner

@lingz lingz commented Jul 13, 2014

pushed as v2.2.3. thanks so much for your help!

fofr added a commit to alphagov/signon that referenced this pull request Jul 15, 2014
* PR lingz/alphabetical_paginate#23 now merged,
fixed HTML markup when using Bootstrap 3 theme
* Switch back from using a forked version of gem
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 15, 2014

@lingz Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.