Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix #75

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Temporary fix #75

merged 1 commit into from
Jun 27, 2017

Conversation

JAremko
Copy link
Contributor

@JAremko JAremko commented Jun 24, 2017

Linkchecker doesn't work with the latest requests
see #74

Linkchecker doesn't work with the latest requests
Copy link
Contributor

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very least we need an explanation for the unusual version specification.

@@ -480,7 +480,7 @@ def get_file_list (self):
},
# Requirements, usable with setuptools or the new Python packaging module.
install_requires = [
'requests >= 2.2.0',
'requests<2.15,>=2.2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd - this is an issue with requests? i don't understand how >=2.2 would be better than >=2.2.0, they should be semantically equivalent...

Copy link
Contributor Author

@JAremko JAremko Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anarcat linkchecker + new requests doesn't work for some reason (but it can be specific for alpinelinux)

this is odd - this is an issue with requests? i don't understand how >=2.2 would be better than >=2.2.0, they should be semantically equivalent.

yeah I just "shortened it" 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... well, we deliberately included this check in 9c9cf0c which fixed wummel/linkchecker#478 - could you clarify how downgrading requests fixes this problem and why this is not a bug with requests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@JAremko JAremko Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also compere two build logs

Building good linkchecker(3 month ago):

Requirement already satisfied: setuptools in /usr/lib/python2.7/site-packages

Collecting git+https://github.com/linkcheck/linkchecker
  Cloning https://github.com/linkcheck/linkchecker to /tmp/pip-AjyRi_-build

Collecting requests>=2.2.0 (from LinkChecker==9.4)

  Downloading requests-2.14.2-py2.py3-none-any.whl (560kB)

Installing collected packages: requests, LinkChecker

  Running setup.py install for LinkChecker: started

    Running setup.py install for LinkChecker: finished with status 'done'

Successfully installed LinkChecker-9.4 requests-2.14.2

Building buggy linkchecker(recent):

Requirement already satisfied: setuptools in /usr/lib/python2.7/site-packages

Collecting git+https://github.com/linkcheck/linkchecker
  Cloning https://github.com/linkcheck/linkchecker to /tmp/pip-WF2jQJ-build

Collecting requests>=2.2.0 (from LinkChecker==9.4)

  Downloading requests-2.18.1-py2.py3-none-any.whl (88kB)

Collecting chardet<3.1.0,>=3.0.2 (from requests>=2.2.0->LinkChecker==9.4)

  Downloading chardet-3.0.4-py2.py3-none-any.whl (133kB)

Collecting certifi>=2017.4.17 (from requests>=2.2.0->LinkChecker==9.4)

  Downloading certifi-2017.4.17-py2.py3-none-any.whl (375kB)

Collecting idna<2.6,>=2.5 (from requests>=2.2.0->LinkChecker==9.4)

  Downloading idna-2.5-py2.py3-none-any.whl (55kB)

Collecting urllib3<1.22,>=1.21.1 (from requests>=2.2.0->LinkChecker==9.4)

  Downloading urllib3-1.21.1-py2.py3-none-any.whl (131kB)

Installing collected packages: chardet, certifi, idna, urllib3, requests, LinkChecker

  Running setup.py install for LinkChecker: started

    Running setup.py install for LinkChecker: finished with status 'done'

Successfully installed LinkChecker-9.4 certifi-2017.4.17 chardet-3.0.4 idna-2.5 requests-2.18.1 urllib3-1.21.1

the last one(requests lib) has a truckload of dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. i see. somehow I thought 2.15 was lower than 2.2.0 :p everything is fine then. i would suggest we keep #74 open to fix 2.15+ support properly, however.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anarcat happens to me all the time 🤣

@anarcat anarcat merged commit 8dc2963 into linkchecker:master Jun 27, 2017
@anarcat
Copy link
Contributor

anarcat commented Jun 27, 2017

Hi,

I hadn't noticed your avatar or profile messages during the discussion here. Please be aware that Linkchecker operates under a code of conduct which include, among other things, "Using welcoming and inclusive language" and "Being respectful of differing viewpoints and experiences". References to symbols defined by the Anti-Defamation League as "racist" qualifies as a breach of this code of conduct.

If you wish to continue participating in this project, you will have to change your profile image and comments.

As a gesture of good faith, this pull request was merged regardless, but future contributions may be refused on those grounds, as explained in the code of conduct.

A.

@JAremko
Copy link
Contributor Author

JAremko commented Jun 27, 2017

@anarcat You gave me link to BBC news 😕 Here is a link to the actually ADL entry

I suggest you pay attention to this segments:

Pepe the Frog character did not originally have racist or anti-Semitic connotations. Internet users appropriated the character and turned him into a meme, placing the frog in a variety of circumstances and saying many different things.

However, because so many Pepe the Frog memes are not bigoted in nature, it is important to examine use of the meme only in context. The mere fact of posting a Pepe meme does not mean that someone is racist or white supremacist.

So perhaps you shouldn't use BBC as your only source of news?

I'm personally support efforts of ADL and Matt Furie(Pepe creator) in Campaign to #SavePepe

We are going to work with Matt and his community of artists reclaim Pepe so that he might be used as a force for good, or at the very least to help educate people about the dangers of prejudice and bigotry.


I have no idea what kind of context you have used to label me as a racist (see article). But here is some:

I'm Ukrainian. My country has a military conflict that killed and displaced thousands of innocent people, our economy is in shambles and our government is beyond incompetent. And while many of my friends are Russians the general public of Ukraine and Russia are zombified and driven mad with hatred towards each other. But we have the online temple of peace and understanding "Runet" the space where all russian speaking people of Post-Soviet states can share their struggle and bound with each other. Pepe become a symbol of this struggle to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants