workaround new limitation in requests #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newer requests do not expose the internal SSL socket object so we cannot verify certificates. there was work to allow custom verification routines which we could use, but this never finished: urllib3/urllib3#257 so right now, just treat missing socket information as if the cert was missing. Closes: linkchecker#76
|
note that this would introduce a regression whereas we cannot verify SSL expiry times with newer requests versions. i'm not sure how to workaround that issue, but at least we would run properly again... |
|
Perhaps we should open a |
|
i thought urllib3/urllib3#257 and https://github.com/kennethreitz/requests/issues/1966 were the upstream issues, but feel free to open another one... |
|
Ah, I didn't see the link to kennethreitz/requests#1966 before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newer requests do not expose the internal SSL socket object so we
cannot verify certificates. there was work to allow custom
verification routines which we could use, but this never finished:
urllib3/urllib3#257
so right now, just treat missing socket information as if the cert was
missing.
Closes: #76