Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No remote context on CoreCLR ? #21

Closed
goofballLogic opened this issue Feb 20, 2018 · 10 comments · Fixed by #78
Closed

No remote context on CoreCLR ? #21

goofballLogic opened this issue Feb 20, 2018 · 10 comments · Fixed by #78

Comments

@goofballLogic
Copy link
Member

goofballLogic commented Feb 20, 2018

A seemingly simple operation of retrieving a remote context document appears not to be supported on .NET Core for some reason????

From https://github.com/NuGet/json-ld.net/blob/master/src/json-ld.net/Core/DocumentLoader.cs#L15

namespace JsonLD.Core
{
    public class DocumentLoader
    {
        /// <exception cref="JsonLDNet.Core.JsonLdError"></exception>
        public virtual RemoteDocument LoadDocument(string url)
        {
#if !PORTABLE && !IS_CORECLR
            . . . snipped . . .
            return doc;
#else
            throw new PlatformNotSupportedException();
#endif
        }

Is this code being used in anger?

@goofballLogic
Copy link
Member Author

I have a patch for this which I can submit as a PR if you're open to it. We need it in our codebase and I'd rather be referencing the nuget version than a private fork.

@CBielstein
Copy link

Just ran in to the same issue when trying out json-ld.net from netcore2.2. I would love to see this PR happen. Let me know if I can help out at all.

@goofballLogic
Copy link
Member Author

goofballLogic commented Feb 20, 2019 via email

@CBielstein
Copy link

I'll add it to my todo list, take a swing at it when I have time, and report back.

@stale
Copy link

stale bot commented May 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 4, 2020
@stale stale bot closed this as completed Jun 3, 2020
@goofballLogic
Copy link
Member Author

Reopening for consideration as part of #60

@stale
Copy link

stale bot commented Sep 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 30, 2020
@asbjornu
Copy link
Member

Ideas for a label we can give these issues to exempt from stalebot, @goofballLogic?

@goofballLogic
Copy link
Member Author

goofballLogic commented Oct 1, 2020

"planned" ?

@asbjornu
Copy link
Member

asbjornu commented Oct 1, 2020

If so, perhaps we can just use milestones? Stalebot can exempt issues associated with milestones as well. If we have an idea of a version number, let's use that as milestone name, otherwise we can just use future, next or something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants