Apply changes to Yext fork of Burrow from rjh-yext #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: 1. Add SASL-SCRAM ability to Kafka connection This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512 It adds an entry in the SASL Profile configuration called key=mechanism value type=string required=no default value=(empty) Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512 Partially addresses linkedin#526 2. Ignore ZooKeeper znode Create if the path already exists Currently, Burrow will attempt to create the znode used by Burrow on startup This will cause problems if there is authentication needed when connecting to zk. The fix is to ignore creating zk node paths if it already exists 3. Yext specific Dockerfile the config file and dir used by Burrow is updated for M4 and Khan 4. Update module and import references go build -o build/Burrow github.com/yext/Burrow pulls in linkedin's branch of Burrow Changing references of linkedin to current fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512
It adds an entry in the SASL Profile configuration called
key=mechanism
value type=string
required=no
default value=(empty)
Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512
Partially addresses #526
Currently, Burrow will attempt to create the znode used by Burrow on startup
This will cause problems if there is authentication needed when connecting
to zk.
The fix is to ignore creating zk node paths if it already exists
the config file and dir used by Burrow is updated for M4 and Khan
go build -o build/Burrow github.com/yext/Burrow
pulls in linkedin's branch of Burrow
Changing references of linkedin to current fork