New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`bluepill --version` doesn't output the version when built from tarball #174

Open
ileitch opened this Issue Jun 22, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@ileitch

ileitch commented Jun 22, 2017

$ bluepill --version
Bluepill

Using 1.1.2 installed via homebrew.

(Easy way to reproduce)

$ curl -sOL https://github.com/linkedin/bluepill/archive/v1.1.2.tar.gz
$ tar xfz v1.1.2.tar.gz
$ (cd bluepill-1.1.2 ; ./scripts/bluepill.sh build) 2>&1 > /dev/null
$ ./bluepill-1.1.2/build/Build/Products/Release/bluepill --version
Bluepill
@oliverhu

This comment has been minimized.

Show comment
Hide comment
@oliverhu

oliverhu Jun 23, 2017

Contributor
$ bluepill --version
Bluepill v1.1.2

from latest build

Contributor

oliverhu commented Jun 23, 2017

$ bluepill --version
Bluepill v1.1.2

from latest build

@ob

This comment has been minimized.

Show comment
Hide comment
@ob

ob Jul 10, 2017

Member

One thing to note is that if homebrew builds Bluepill from the published source code (zip file) and not from the git repository, the version will be wrong. Maybe this is what's happening...

Member

ob commented Jul 10, 2017

One thing to note is that if homebrew builds Bluepill from the published source code (zip file) and not from the git repository, the version will be wrong. Maybe this is what's happening...

@ileitch

This comment has been minimized.

Show comment
Hide comment
@ileitch

ileitch Jul 12, 2017

It does indeed use the published zip:

➜  ~ brew install -v bluepill
==> Downloading https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz
/usr/bin/curl --remote-time --location --user-agent Homebrew/1.2.4 (Macintosh; Intel Mac OS X 10.12.5) curl/7.51.0 --fail https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz -C 0 -o /Users/ian/Library/Caches/Homebrew/bluepill-1.1.2.sierra.bottle.tar.gz.incomplete
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100  204k  100  204k    0     0  59698      0  0:00:03  0:00:03 --:--:-- 94891
==> Verifying bluepill-1.1.2.sierra.bottle.tar.gz checksum
==> Pouring bluepill-1.1.2.sierra.bottle.tar.gz
tar xzf /Users/ian/Library/Caches/Homebrew/bluepill-1.1.2.sierra.bottle.tar.gz
==> Finishing up
ln -s ../Cellar/bluepill/1.1.2/bin/bluepill bluepill
ln -s ../Cellar/bluepill/1.1.2/bin/bp bp
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20170712-19805-1ifw26b.sb nice /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/postinstall.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/bluepill.rb -v
==> Summary
🍺  /usr/local/Cellar/bluepill/1.1.2: 7 files, 679.4KB

ileitch commented Jul 12, 2017

It does indeed use the published zip:

➜  ~ brew install -v bluepill
==> Downloading https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz
/usr/bin/curl --remote-time --location --user-agent Homebrew/1.2.4 (Macintosh; Intel Mac OS X 10.12.5) curl/7.51.0 --fail https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz -C 0 -o /Users/ian/Library/Caches/Homebrew/bluepill-1.1.2.sierra.bottle.tar.gz.incomplete
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100  204k  100  204k    0     0  59698      0  0:00:03  0:00:03 --:--:-- 94891
==> Verifying bluepill-1.1.2.sierra.bottle.tar.gz checksum
==> Pouring bluepill-1.1.2.sierra.bottle.tar.gz
tar xzf /Users/ian/Library/Caches/Homebrew/bluepill-1.1.2.sierra.bottle.tar.gz
==> Finishing up
ln -s ../Cellar/bluepill/1.1.2/bin/bluepill bluepill
ln -s ../Cellar/bluepill/1.1.2/bin/bp bp
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20170712-19805-1ifw26b.sb nice /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/postinstall.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/bluepill.rb -v
==> Summary
🍺  /usr/local/Cellar/bluepill/1.1.2: 7 files, 679.4KB
@ileitch

This comment has been minimized.

Show comment
Hide comment
@ileitch

ileitch Jul 12, 2017

Although saying that, https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz isn't your official archive URL. Though the formula does reference the correct URL: https://github.com/Homebrew/homebrew-core/blob/master/Formula/bluepill.rb#L4

ileitch commented Jul 12, 2017

Although saying that, https://homebrew.bintray.com/bottles/bluepill-1.1.2.sierra.bottle.tar.gz isn't your official archive URL. Though the formula does reference the correct URL: https://github.com/Homebrew/homebrew-core/blob/master/Formula/bluepill.rb#L4

@ob

This comment has been minimized.

Show comment
Hide comment
@ob

ob Jul 12, 2017

Member

Yeah, I think that's just a binary cache... the problem is that our published source lacks a version, it fetches the version dynamically from git. I think we need to update our publishing workflow to add the version information.

Member

ob commented Jul 12, 2017

Yeah, I think that's just a binary cache... the problem is that our published source lacks a version, it fetches the version dynamically from git. I think we need to update our publishing workflow to add the version information.

@ob ob changed the title from `bluepill --version` doesn't output the version to `bluepill --version` doesn't output the version when built from tarball Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment