Skip to content
Branch: master
Commits on Nov 7, 2019
  1. Merge pull request #347 from linkedin/import-autocomplete

    jackson-dean committed Nov 7, 2019
    Import autocomplete
Commits on Nov 6, 2019
  1. refactor: Make error handling for readdir and stat more explicit.

    jackson-dean committed Nov 6, 2019
    This also pins node to the version used by electron which is the version
    we will be running against in the vscode extension environment.
  2. fix: Handle possible fs.stat failure gracefully.

    jackson-dean committed Nov 6, 2019
  3. refactor: Remove the use of glob for file path completions.

    jackson-dean committed Nov 6, 2019
    This was using glob naively to filter the completion items sent back to
    the client editor. However, this is not really necessary since the client
    filters the list the UI as the user types.
Commits on Nov 5, 2019
  1. chore: Remove unecessary completion trigger character.

    jackson-dean committed Nov 5, 2019
  2. feat: Implement autocomplete for import paths.

    jackson-dean committed Nov 5, 2019
Commits on Nov 4, 2019
Commits on Oct 31, 2019
  1. feat: Add document links provider.

    jackson-dean committed Oct 31, 2019
    For css and sass, vscode provides a "jump to file" feature for @import and
    `url()` statements. For css-blocks, we only need to add this support for
    custom "at rules" (@block, @export). For `url()`, the builtin vscode css
    language server should still be providing that functionality.
Commits on Oct 28, 2019
  1. refactor: Refactor tests to account for css-blocks syntax changes.

    jackson-dean committed Oct 28, 2019
    The refactoring of the app code to handle the new css-blocks syntax changes
    have already been implemented by @chriseppstein. This is refactoring tests
    and test fixtures to get them passing.
    NOTE: there is still one failing test for handling classes that are defined
    multiline string. That will require app code changes. I will handle that in
    an isolation.
Commits on Oct 17, 2019
  1. refactor: Refactor the server to allow for easier testing.

    jackson-dean committed Oct 3, 2019
    - Create a class for the server to make it easier to create an instance
    and inject dependencies for testing.
    - Migrates logic that can be isolated from the server to separate modules.
    - Add some high level integration tests for the server.
    - Refactor to handle various edge cases (baretext attributes, multi-line
    class strings, etc).
    - Includes support and test coverage for the following use cases:
      * Go to definition (from template) for local block and exported block.
      * Auto complete (from template) for local block and exported block.
      * Error reporting in template for classes that are not defined (updated on file save).
      * Error reporting in css files for css block errors (updated on file change).
    - The current iteration only supports plain css syntax. There is more
    work to do to support other syntaxes (sass, less, etc).
    - There is special attention paid here to supporting ember template syntax. There
    is still work to be done to support other frameworks or libraries.
  2. chore: Add lint and test scripts to language-server module.

    jackson-dean committed Oct 1, 2019
    - Update yarn scripts config files to the langauge-server module for lint,
    compiling typescript, and running tests.
    - Change build output directory from `out` to `dist` to match the existing
    monorepo conventions.
    - Add mocha options and a minimal test to confirm everything is working.
Commits on Sep 19, 2019
  1. feat: Basic workings of language server and vscode client.

    jackson-dean authored and chriseppstein committed Sep 19, 2019
  2. feat: Basic workings of language server and vscode client.

    jackson-dean authored and chriseppstein committed Sep 19, 2019
You can’t perform that action at this time.