Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import autocomplete #347

Merged
merged 7 commits into from Nov 7, 2019

Conversation

@jackson-dean
Copy link
Member

jackson-dean commented Nov 5, 2019

No description provided.

Copy link
Contributor

chriseppstein left a comment

Looks good! I have some questions and a few issues before we merge it.

jackson-dean added 2 commits Nov 6, 2019
This was using glob naively to filter the completion items sent back to
the client editor. However, this is not really necessary since the client
filters the list the UI as the user types.
@jackson-dean jackson-dean force-pushed the import-autocomplete branch from fdf985e to 417f789 Nov 6, 2019
This also pins node to the version used by electron which is the version
we will be running against in the vscode extension environment.
@jackson-dean jackson-dean force-pushed the import-autocomplete branch from 417f789 to a916433 Nov 6, 2019
Copy link
Contributor

chriseppstein left a comment

Just a couple of small things and I think it's good to go!

@jackson-dean jackson-dean merged commit e9083e0 into master Nov 7, 2019
13 checks passed
13 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/broccoli/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/code-style/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/core/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/ember-cli/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/glimmer/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/jsx/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/playground/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/runtime/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/webpack/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/website/package.json (chriseppstein) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.